Merged
Conversation
valeriaRaffuzzi
requested changes
Feb 24, 2026
Member
valeriaRaffuzzi
left a comment
valeriaRaffuzzi
left a comment
There was a problem hiding this comment.
All very nice! Just a few comments but nothing major, very excited to merge alpha soon!
NuclearData/ceNeutronData/aceDatabase/aceNeutronNuclide_class.f90
Outdated
Show resolved
Hide resolved
Collaborator
Author
|
I think that's all the changes - let me know! |
valeriaRaffuzzi
approved these changes
Feb 26, 2026
Member
valeriaRaffuzzi
left a comment
valeriaRaffuzzi
left a comment
There was a problem hiding this comment.
Looks good to me, thanks for addressing all the changes!!
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This contains the modifications and physicsPackage needed to solve alpha eigenvalue problems. This adds alpha and a stabilisation factor, eta, to the particle, and obtains the appropriate alpha cross section during transport. I also included Cullen's example problems. I also added an implicit removal time tally.
While doing this, I made some small tweaks to kinetic to improve the performance of combing as mentioned in issue #195, added optional time dependence to materialSource (which we should probably make more general in future) and fixed a bug in the kineticPhysicsPackage which prevented the time dependence of sources from being properly accounted for.
Finally, I added an optional to keffImplicitClerk to tally only prompt or delayed neutron production, rather than the total that we previously had.