Skip to content

Improve error logging observability for created_via_invite rollout #1607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
riderx merged 2 commits into from
Feb 9, 2026
Merged

Improve error logging observability for created_via_invite rollout #1607

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1e12ea1
Initial plan
Copilot Feb 9, 2026
b8e53fb
feat: log all initial insert errors before retry decision
Copilot Feb 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 18 additions & 2 deletions supabase/functions/_backend/private/accept_invitation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,12 +146,20 @@ async function ensurePublicUserRowExists(

let { error: insertError } = await supabaseAdmin.from('users').insert(insertPayload)

// Log any initial error for observability during rollout
if (insertError) {
cloudlog({
requestId: c.get('requestId'),
message: 'ensurePublicUserRowExists: initial insert error',
error: insertError,
})
}
Comment on lines +149 to +156
Copy link

Copilot AI Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These logs are recording insert failures; consider using cloudlogErr (stderr) instead of cloudlog so error-level logs can be filtered/alerted consistently across runtimes.

Copilot uses AI. Check for mistakes.

// Backward compatible rollout: if the column doesn't exist yet, retry without it.
if (isMissingCreatedViaInviteColumnError(insertError)) {
cloudlog({
requestId: c.get('requestId'),
message: 'ensurePublicUserRowExists: created_via_invite column missing, retrying without it',
error: insertError,
})
const { created_via_invite: _createdViaInvite, ...fallbackPayload } = insertPayload
;({ error: insertError } = await supabaseAdmin.from('users').insert(fallbackPayload))
Expand Down Expand Up @@ -444,12 +452,20 @@ app.post('/', async (c) => {
data,
} = await supabaseAdmin.from('users').insert(insertUserPayload).select().single()

// Log any initial error for observability during rollout
if (userNormalTableError) {
cloudlog({
requestId: c.get('requestId'),
message: 'accept_invitation: initial user insert error',
error: userNormalTableError,
})
}
Comment on lines +455 to +462
Copy link

Copilot AI Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is logging an actual insert error; consider emitting it via cloudlogErr (stderr) instead of cloudlog to keep error logs consistent and easier to detect in production logging pipelines.

Copilot uses AI. Check for mistakes.

// Backward compatible rollout: if the column doesn't exist yet, retry without it.
if (isMissingCreatedViaInviteColumnError(userNormalTableError)) {
cloudlog({
requestId: c.get('requestId'),
message: 'accept_invitation: created_via_invite column missing, retrying without it',
error: userNormalTableError,
})
const { created_via_invite: _createdViaInvite, ...fallbackPayload } = insertUserPayload
;({ error: userNormalTableError, data } = await supabaseAdmin.from('users').insert(fallbackPayload).select().single())
Expand Down
Loading