Skip to content

Simplify allow_device_custom_id query - remove unnecessary COALESCE #1627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
riderx merged 4 commits into from
Feb 13, 2026
Merged

Simplify allow_device_custom_id query - remove unnecessary COALESCE #1627

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d362479
Initial plan
Copilot Feb 12, 2026
8aeaf9a
Fix COALESCE query to handle NULL values when column doesn't exist
Copilot Feb 12, 2026
dc796bf
Fix has_usage_credits COALESCE query with same issue
Copilot Feb 12, 2026
af6c362
Simplify allow_device_custom_id query - remove unnecessary COALESCE
Copilot Feb 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions supabase/functions/_backend/plugins/stats.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import type { MiddlewareKeyVariables } from '../utils/hono.ts'
import type { Database } from '../utils/supabase.types.ts'
import type { AppStats, StatsActions } from '../utils/types.ts'
import { greaterOrEqual, parse } from '@std/semver'
import { eq, sql } from 'drizzle-orm'
import { eq } from 'drizzle-orm'
import { Hono } from 'hono/tiny'
import { z } from 'zod/mini'
import { getAppStatus, setAppStatus } from '../utils/appStatus.ts'
Expand All @@ -24,9 +24,7 @@ const PLAN_ERROR = 'Cannot send stats, upgrade plan to continue to update'
async function allowDeviceCustomIdFromPg(drizzleClient: ReturnType<typeof getDrizzleClient>, app_id: string): Promise<boolean> {
const res = await drizzleClient
.select({
// Replicas may lag schema changes. Read via to_jsonb(row)->>... so the
// query still parses even if the column doesn't exist yet.
allow_device_custom_id: sql<boolean>`COALESCE((to_jsonb(apps) ->> 'allow_device_custom_id')::boolean, true)`,
allow_device_custom_id: schema.apps.allow_device_custom_id,
})
.from(schema.apps)
.where(eq(schema.apps.app_id, app_id))
Expand Down
Loading