Skip to content

Add missing java packaging#7

Merged
rmonat merged 3 commits intomainfrom
package-java
May 7, 2025
Merged

Add missing java packaging#7
rmonat merged 3 commits intomainfrom
package-java

Conversation

@vincent-botbol
Copy link
Contributor

@vincent-botbol vincent-botbol commented Apr 24, 2025

This PR fixes the missing installation of the Java files. We (@AltGr & myself) figured that copying over the Java files as is would be better than to depends on Java. Hence, it's the user's responsibility to compile the java files as needed.

@vincent-botbol vincent-botbol requested review from AltGr and rmonat April 24, 2025 15:22
Copy link
Collaborator

@rmonat rmonat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you!

Could you maybe add a runtest target executing the java tests as well? No need for the dependencies to be added in the opam file, but I think it would be nice to still have the tests running for all implementations of dates-calc.

@vincent-botbol
Copy link
Contributor Author

vincent-botbol commented May 6, 2025

Looks good to me, thank you!

Could you maybe add a runtest target executing the java tests as well? No need for the dependencies to be added in the opam file, but I think it would be nice to still have the tests running for all implementations of dates-calc.

Following offline discussions, ocaml/opam-repository#27813 has been merged. We can now add the dependency to the opam file and run the java test through dune runtest (given that the CI's opam repository is up-to-date).

@rmonat rmonat merged commit 9ef445d into main May 7, 2025
2 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Catala - language & tooling May 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants