-
Notifications
You must be signed in to change notification settings - Fork 759
IDE-305 Fix URLs and remove obsolete buttons #5126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
wslany
wants to merge
37
commits into
Catrobat:develop
Choose a base branch
from
wslany:wslany-release-preparation-fixes
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On the main Catroid landing page, the main menu (top right) shows these two (or three) menu options, but they are not valid anymore. This just removes access to them. The correpsonding code still remains, and maybe be removable in future releases, e.g., via https://catrobat.atlassian.net/browse/IDE-301
Updated various URLs in Constants.java to point to the correct documentation and legal pages.
Just in case...
Removed upload project functionality from MainMenuFragment.
Removed test for back button behavior after tapping upload button since that buttn does not exist anymore on the main menu fragment.
Removed the uploadProject test method from ProjectOptionsTest since we removed the upload functionality to share.catrob.at
Removed project upload functionality from ProjectOptionsFragment.
Updated URLs for Catrobat documentation and wiki references. Unfortunately the original wiki pages apparently were lost without backup. Some of them may still exist on the internet archive site at https://archive.org/
Removed the onSaveProjectComplete function to streamline project saving process.
Removed unused imports from MainMenuFragment.kt
Removed unused imports from ProjectOptionsFragment.kt
Incorrect comment symbol.
Removed login and logout options from the menu.
Removed the TextView for project upload options.
Since we do not have remote projects anymore, all projects now are "on device". And there is no Catrobat community at the moment, so we redirect to the Catrobat website.
Since this URL is shown under the Catrobat (formely "Catrobat community") link on the app's landing page and previously led to our notice that the server does not exist anymore.
Since this URL is shown under the Catrobat (formely "Catrobat community") link on the app's landing page and previously led to our notice that the server does not exist anymore.
Since this URL is shown under the Catrobat (formely "Catrobat community") link on the app's landing page and previously led to our notice that the server does not exist anymore.
Revert incorrect change to rebased develop branch
Revert incorrect change to rebased develop branch
Revert incorrect change to rebased develop branch
Revert incorrect change to rebased develop branch
Revert incorrect change to rebased develop branch
Revert incorrect change to rebased develop branch
Revert incorrect change to rebased develop branch
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.



Fixed bad URLs to point to correct informaton.
Removed buttons and menu entries to obsolete features such as the Scratch converter or Uploading of projects to share.
https://catrobat.atlassian.net/browse/IDE-305
Your checklist for this pull request
Please review the contributing guidelines and wiki pages of this repository.