Skip to content

Fixed simple field None value #239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
botzill wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixed simple field None value #239

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions pydocx/openxml/wordprocessing/simple_field.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,8 @@ def _parse_instr_arg_string_to_args(self, arg_string):
return re.findall(r'\s*(?:"([^"]+)"|([^\s]+))+', arg_string)

def parse_instr(self):
if self.instr is None:
return
m = self._parse_instr_into_field_type_and_arg_string()
if not m:
return
Expand Down
4 changes: 4 additions & 0 deletions tests/export/html/test_simple_field.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,6 +202,10 @@ def parse(self, instr):
field = SimpleField(instr=instr)
return field.parse_instr()

def test_with_None_instr_returns_None(self):
result = self.parse(None)
self.assertEqual(result, None)

def test_with_blank_instr_returns_None(self):
result = self.parse('')
self.assertEqual(result, None)
Expand Down