Skip to content

Fixed property name of normal texture info#313

Merged
kring merged 2 commits intomainfrom
fix-normal-texture-property-name
Aug 24, 2021
Merged

Fixed property name of normal texture info#313
kring merged 2 commits intomainfrom
fix-normal-texture-property-name

Conversation

@javagl
Copy link
Contributor

@javagl javagl commented Aug 17, 2021

According to the specification, the property name for the normal texture should be normalTexture (its type is called normalTextureInfo, but not the property).

This caused a validation error

UNEXPECTED_PROPERTY | Unexpected property. | /materials/0/normalTextureInfo

for assets that contained a normal texture.

This PR just fixes that property name.

@kring
Copy link
Member

kring commented Aug 24, 2021

The writers have been overhauled in #307, but this looks like a good change in the meantime. Thanks!

@kring kring merged commit 37946d3 into main Aug 24, 2021
@kring kring deleted the fix-normal-texture-property-name branch August 24, 2021 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments