Merged
Conversation
Member
|
Thanks @lilleyse! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new project
Cesium3DTilesWriterthat serializes aTilesetstruct to a tileset JSON.Much of this work is built on top of #306 and #307 with similar generated code and improved handling of extensions, extras, and default values.
@krupkad's original summary still mostly applies
The code generation is split between
generate.jsandgenerateCombinedWriter.js.generate.jscreates the pieces for each writer andgenerateCombinedWriter.jscombines them into a single header and cpp file. There's special handling for default values. We don't write a property ifmatrixandtranslation/rotation/scaleare mutually exclusive and we shouldn't write out default values for both.The code has been tested with both 3D Tiles (this PR) and glTF (follow up PR) and seems to produce valid results for both, though there could be lingering issues with the default value checks.