EXT_feature_metadata: Restrictions on string IDs, add property table and texture names#18
Merged
ptrgags merged 1 commit intoCesiumGS:3d-tiles-next-revfrom Sep 27, 2021
Conversation
Member
Author
ptrgags
reviewed
Sep 22, 2021
ptrgags
left a comment
ptrgags
left a comment
There was a problem hiding this comment.
@donmccurdy changes look good, though I noticed some little details about identifiers we haven't considered.
Member
Author
|
Converted this PR to a draft – hoping to merge #19 first unless it looks like delays are likely there. |
lilleyse
force-pushed
the
3d-tiles-next-rev
branch
from
36ceb70 to
ea7479e
Compare
… on feature tables and textures.
donmccurdy
force-pushed
the
ext-feature-metadata-v2.5
branch
from
e80d81a to
3fd0830
Compare
|
Looks good, thanks @donmccurdy! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
Expectation here is that human-readable names may be provided in the "name" property if restrictions don't allow it in the string ID. In languages requiring non-ASCII characters it may be convenient to use IDs like
"property01"and more meaningful names.