Draft extension for SPZ compression support for Gaussian splats#81
Draft extension for SPZ compression support for Gaussian splats#81keyboardspecialist wants to merge 33 commits into3d-tiles-nextfrom
Conversation
Co-authored-by: Adam Morris <adam@kernelpanicstudios.com>
Co-authored-by: Adam Morris <adam@kernelpanicstudios.com>
…e extension rather than building on KHR_gaussian_splatting
lilleyse
left a comment
There was a problem hiding this comment.
Looks pretty good. Just a few comments from me.
extensions/2.0/Khronos/KHR_spz_gaussian_splats_compression/README.md
Outdated
Show resolved
Hide resolved
extensions/2.0/Khronos/KHR_spz_gaussian_splats_compression/README.md
Outdated
Show resolved
Hide resolved
...ian_splats_compression/schema/mesh.primitive.KHR_spz_gaussian_splats_compression.schema.json
Outdated
Show resolved
Hide resolved
extensions/2.0/Khronos/KHR_spz_gaussian_splats_compression/README.md
Outdated
Show resolved
Hide resolved
extensions/2.0/Khronos/KHR_spz_gaussian_splats_compression/README.md
Outdated
Show resolved
Hide resolved
extensions/2.0/Khronos/KHR_spz_gaussian_splats_compression/README.md
Outdated
Show resolved
Hide resolved
extensions/2.0/Khronos/KHR_spz_gaussian_splats_compression/README.md
Outdated
Show resolved
Hide resolved
extensions/2.0/Khronos/KHR_spz_gaussian_splats_compression/README.md
Outdated
Show resolved
Hide resolved
extensions/2.0/Khronos/KHR_spz_gaussian_splats_compression/README.md
Outdated
Show resolved
Hide resolved
…DME.md Co-authored-by: Sean Lilley <lilleyse@gmail.com>
…DME.md Co-authored-by: Sean Lilley <lilleyse@gmail.com>
…DME.md Co-authored-by: Sean Lilley <lilleyse@gmail.com>
…DME.md Co-authored-by: Sean Lilley <lilleyse@gmail.com>
|
I did something I shouldn't have and managed to completely pollute the history for this branch. I will try to clean it up later. @lilleyse - when you have a moment another review pass is appreciated. |
| "max": [ | ||
| 1, | ||
| 1, | ||
| 1, | ||
| ], | ||
| "min": [ | ||
| -1, | ||
| -1, | ||
| -1, | ||
| ] |
There was a problem hiding this comment.
This is required by the glTF spec for all POSITION accessors.
In reality, we should probably calculate the actual bounds, but right now this is good enough since we don't need them for implementation.
A good ask for the working group is if we can relax this requirement when our extension is in use.
There was a problem hiding this comment.
A good ask for the working group is if we can relax this requirement when our extension is in use.
I changed my mind about this. I think there's still potential for these bounds to be very useful in some engines. We should still require these bounds to be properly calculated.
|
I was able to fix the history by
Though none of this will matter once a PR is opened in the Khronos repo (at least I don't see the need to keep the commit history) |
lilleyse
left a comment
There was a problem hiding this comment.
Just a few small comments from me. I like how simple the extension schema is now.
extensions/2.0/Khronos/KHR_spz_gaussian_splats_compression/README.md
Outdated
Show resolved
Hide resolved
extensions/2.0/Khronos/KHR_spz_gaussian_splats_compression/README.md
Outdated
Show resolved
Hide resolved
extensions/2.0/Khronos/KHR_spz_gaussian_splats_compression/README.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Sean Lilley <lilleyse@gmail.com>
Co-authored-by: Sean Lilley <lilleyse@gmail.com>
|
I'm going to close this PR and create a new branch cherry picked from this one. While Sean fixed the issue for our review purposes, my mishap still creates quite a mess for a PR into the official glTF repo. |
|
Reopened in the Khronos Group glTF repo: KhronosGroup#2490 |
|
GISBox now fully supports the KHR_spz_gaussian_splats_compression slicing function. This feature, through an innovative slicing compression algorithm, significantly improves the transmission efficiency and rendering performance of Gaussian splatting point cloud data. |
Follows EXT_draco_mesh_compression as pattern.