Skip to content

Use floats for numeric default args #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kwabenantim merged 1 commit into from
Nov 26, 2024
Merged

Use floats for numeric default args #68

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 5 additions & 15 deletions cppwg/utils/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ def read_source_file(
return source


def str_to_num(expr: str) -> Number:
def str_to_num(expr: str) -> float:
"""
Convert a literal string expression to a number e.g. "(-1)" to -1.

Expand All @@ -183,24 +183,14 @@ def str_to_num(expr: str) -> Number:

Returns
-------
Number
float
The converted number, or None if the conversion fails
"""
expr = expr.strip()
if expr.isnumeric():
return int(expr)

try:
result = float(expr)
return result
except ValueError:
pass

try:
result = ast.literal_eval(expr)
result = ast.literal_eval(expr.strip())
if isinstance(result, Number):
return result
except (ValueError, SyntaxError):
return float(result)
except (SyntaxError, TypeError, ValueError):
pass

return None
Expand Down