fix: Bind OAuth callback server to localhost #11956
Merged
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the server to listen explicitly on 127.0.0.1 instead of all interfaces. The log message was also updated to reflect the new binding address.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enhances the security of the OAuth callback server by explicitly binding it to localhost (127.0.0.1) instead of all network interfaces. This is a security best practice for OAuth flows in desktop applications, preventing potential network-based attacks on the callback endpoint. The change aligns with the existing OAuth provider configuration which already constructs redirect URLs using http://127.0.0.1.
- Binds the OAuth callback server to 127.0.0.1 instead of the default 0.0.0.0 (all interfaces)
- Updates the log message to reflect the specific binding address for better observability
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the server to listen explicitly on 127.0.0.1 instead of all interfaces. The log message was also updated to reflect the new binding address.
Reference:
MCPJam/inspector#1095
nbonamy/witsy@a23d4e5