Skip to content

Set VDF_MODE according to the passed env var, and make it 1 on the CI test workflows #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
AmineKhaldi wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Set VDF_MODE according to the passed env var, and make it 1 on the CI test workflows #235

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
204ab42
Set VDF_MODE according to the passed env var, and make it 1 on the CI…
AmineKhaldi Feb 5, 2025
d3b5aaf
Explore adapting repeated_square_original call to its current signature.
AmineKhaldi Feb 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,13 +36,14 @@ jobs:
run: |
sudo apt-get install libgmp-dev libboost-python-dev libpython3-dev libboost-system-dev build-essential -y
cd src
make ${{ matrix.config }} -f Makefile.vdf-client
VDF_MODE=1 make ${{ matrix.config }} -f Makefile.vdf-client

- name: Build vdf-client on Mac
if: startsWith(matrix.os, 'mac')
run: |
brew install boost
cd src
# TODO: Are we expected to fail to compile with VDF_MODE=1 on macOS
make ${{ matrix.config }} -f Makefile.vdf-client

- name: Test vdf-client
Expand Down
4 changes: 3 additions & 1 deletion src/Makefile.vdf-client
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,9 @@ endif

LDFLAGS += -flto $(NOPIE) -g
LDLIBS += -lgmpxx -lgmp -lboost_system -pthread
CXXFLAGS += -flto -std=c++1z -D VDF_MODE=0 -D FAST_MACHINE=1 -pthread $(NOPIE) -fvisibility=hidden

VDF_MODE ?= 0
CXXFLAGS += -flto -std=c++1z -D VDF_MODE=$(VDF_MODE) -D FAST_MACHINE=1 -pthread $(NOPIE) -fvisibility=hidden
ifeq ($(UNAME),Darwin)
CXXFLAGS += -D CHIAOSX=1
endif
Expand Down
2 changes: 1 addition & 1 deletion src/vdf.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,7 @@ void repeated_square(uint64_t iterations, form f, const integer& D, const intege
form f_copy_2=f;
weso->reduce(f_copy_2);

repeated_square_original(*weso->vdfo, f_copy, D, L, actual_iterations);
repeated_square_original(*weso->vdfo, f_copy, D, L, actual_iterations, 1, NULL);
assert(f_copy==f_copy_2);
}
#endif
Expand Down
Loading