enhance upload method to support new Lychee API#6
Open
engineerjoe440 wants to merge 10 commits intoChostakovitch:mainfrom
Open
enhance upload method to support new Lychee API#6engineerjoe440 wants to merge 10 commits intoChostakovitch:mainfrom
engineerjoe440 wants to merge 10 commits intoChostakovitch:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drat! 😦 I just found what appears to be a bug.
It seems that the most recent versions of Lychee require an additional parameter when uploading a photo. They seem to complain:
{ "errors": { "fileLastModifiedTime": [ "The file last modified time field is required." ] }, "message": "The file last modified time field is required." }And it seems to require an integer:
{ "errors": { "fileLastModifiedTime": [ "The file last modified time must be a number." ] }, "message": "The file last modified time must be a number." }This pull-request addresses that issue. I'm able to build this into my system, locally. So feel free to take your time to evaluate, but I think it will likely need to be pulled in at some point.