pw locators, actions and assertions by ChrissyDev · Pull Request #1 · ChrissyDev/aqa-pw

ChrissyDev · 2024-04-08T16:12:59Z

No description provided.

sttaran

I would expect more negative scenarios

And make them please as dedicated tests

sttaran · 2024-04-08T19:52:24Z

tests/qauto/homework1.spec.js

+test.describe('Registration form test', () => {
+
+    test.beforeEach(async ({page})=>{
+        await page.goto("https://qauto.forstudy.space/");


you baseUrl in you playwright config, use relative path

sttaran · 2024-04-08T19:53:17Z

tests/qauto/homework1.spec.js

+    await page.locator("#signupName").fill("Justin");
+    await page.locator("#signupLastName").fill("Potter");
+    await page.locator("#signupEmail").fill("dns-jp@test.com");
+    await page.locator("#signupPassword").fill("qwertY@123");
+    await page.locator("#signupRepeatPassword").fill("qwertY@123");


do not hardcode values

after you have it moved to variables you can get rid of expectedName, expectedLastName etc.

sttaran · 2024-04-08T19:54:13Z

tests/qauto/homework1.spec.js

+    expect(passworRepeatdValue).toBe(expectedRepeatValue);
+
+    await page.getByText("Register").click();
+    await expect(page).toHaveURL('https://qauto.forstudy.space/panel/garage')


use relative path

sttaran · 2024-04-08T19:55:38Z

tests/qauto/homework1.spec.js

+    await page.locator("#signupPassword").click();
+    await expect(page.getByText("Email required")).toBeVisible();
+    await page.locator("#signupRepeatPassword").click();
+    await expect(page.getByText("Password required")).toBeVisible();


you do not know where this error appears, use more precise locators

sttaran · 2024-04-08T19:55:47Z

tests/qauto/homework1.spec.js

+        return style.borderColor;
+      });
+
+      expect(computedStyle).toBe('rgb(220, 53, 69)');


use https://playwright.dev/docs/api/class-locatorassertions#locator-assertions-to-have-css

sttaran · 2024-04-08T19:56:01Z

tests/qauto/homework1.spec.js

+
+  test('Empty fields', async ({page})=>{
+    await page.locator("#signupName").click();
+    await page.locator("#signupLastName").click();


use https://playwright.dev/docs/api/class-locator#locator-focus

still not resolved

sttaran · 2024-04-08T19:56:52Z

tests/qauto/homework1.spec.js

+    const expectedValue = "qwertY@123";
+    expect(passwordValue).toBe(expectedValue);
+
+    const passworRepeatdValue = await page.locator("#signupPassword").evaluate(element => element.value);


use https://playwright.dev/docs/api/class-locator#locator-inner-text
or even better
https://playwright.dev/docs/api/class-locatorassertions#locator-assertions-to-have-text

still not resolved

sttaran · 2024-04-14T19:40:42Z

tests/qauto/homework1.spec.js

+    const expectedValue = "qwertY@123";
+    expect(passwordValue).toBe(expectedValue);
+
+    const passworRepeatdValue = await page.locator("#signupPassword").evaluate(element => element.value);


still not resolved

sttaran · 2024-04-14T19:41:33Z

tests/qauto/homework1.spec.js

+
+  test('Empty fields', async ({page})=>{
+    await page.locator("#signupName").click();
+    await page.locator("#signupLastName").click();


still not resolved

sttaran · 2024-04-14T19:42:14Z

tests/qauto/homework1.spec.js

+    await page.locator("#signupLastName").click();
+    await expect(page.locator("#signupName + .invalid-feedback")).toBeVisible();
+    await page.locator("#signupEmail").click();
+    await expect(page.locator("#signupLastName + .invalid-feedback")).toBeVisible();


save this locator to variable

you have to many duplicated selectors

sttaran · 2024-04-28T12:42:27Z

pageObjects/RegistrationPage.js

+      this.signupNameInput = '#signupName';
+      this.signupLastNameInput = '#signupLastName';
+      this.signupEmailInput = '#signupEmail';
+      this.signupPasswordInput = '#signupPassword';
+      this.signupRepeatPasswordInput = '#signupRepeatPassword';
+      this.registerButton = 'text=Register';


create locators instead of selectors

move this fields to a components such as RegistrationPopup

sttaran · 2024-04-28T12:43:57Z

pageObjects/RegistrationPage.js

+      await this.page.fill(this.signupNameInput, name);
+      await this.page.fill(this.signupLastNameInput, lastName);
+      await this.page.fill(this.signupEmailInput, email);
+      await this.page.fill(this.signupPasswordInput, password);
+      await this.page.fill(this.signupRepeatPasswordInput, password);


page.fill is not recommended

sttaran · 2024-04-28T12:45:07Z

pageObjects/RegistrationPage.js

+    async validateRedBorder() {
+      await expect(this.page.locator(this.signupNameInput)).toHaveCSS('border-color', 'rgb(220, 53, 69)');
+      await expect(this.page.locator(this.signupLastNameInput)).toHaveCSS('border-color', 'rgb(220, 53, 69)');
+      await expect(this.page.locator(this.signupEmailInput)).toHaveCSS('border-color', 'rgb(220, 53, 69)');
+      await expect(this.page.locator(this.signupPasswordInput)).toHaveCSS('border-color', 'rgb(220, 53, 69)');
+      await expect(this.page.locator(this.signupRepeatPasswordInput)).toHaveCSS('border-color', 'rgb(220, 53, 69)');
+    }


page objects are for interacting with page

assertions should not be in POM

this method btw in not universal since you can't check only one field with it

sttaran · 2024-04-28T12:47:30Z

pageObjects/RegistrationPage.js

@@ -0,0 +1,54 @@
+import { test, expect } from "@playwright/test";
+
+export default class RegistrationPage {


There is no registration page as well as login page

You can call it MainPage or WelcomePage or smth like that

sttaran · 2024-04-28T12:48:06Z

tests/qauto/homework1.spec.js

+    const name = await page.locator('#signupName').evaluate(element => element.value);
+    expect(name).toBe(signupName);


use https://playwright.dev/docs/api/class-locatorassertions#locator-assertions-to-have-value

sttaran · 2024-04-28T12:48:28Z

tests/qauto/homework1.spec.js

+    const name = await page.locator('#signupName').evaluate(element => element.value);
+    expect(name).toBe(signupName);
+
+    const lastName = await page.locator('#signupLastName').evaluate(element => element.value);


do not use selectors in tests

pw locators, actions and assertions

e19dc0a

sttaran suggested changes Apr 8, 2024

View reviewed changes

homework-1 fix-1

87ef14e

sttaran suggested changes Apr 14, 2024

View reviewed changes

Homework 19 long overdue

1cbf94a

sttaran suggested changes Apr 28, 2024

View reviewed changes

		@@ -0,0 +1,54 @@
		import { test, expect } from "@playwright/test";

		export default class RegistrationPage {

		const name = await page.locator('#signupName').evaluate(element => element.value);
		expect(name).toBe(signupName);

Conversation

ChrissyDev commented Apr 8, 2024

Uh oh!

sttaran left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants