Add ability to build from git checkout, or obtain sources elsewhere.#50
Merged
val-ms merged 4 commits intoCisco-Talos:masterfrom Feb 26, 2026
Merged
Conversation
build steps. In order to support some specialized build environments (i.e. Google), it is necessary to provide the ability to obtain sources via other means. This commit adds this functionality, and a future commit will add recipes which use these new features. CLAM-2938
val-ms
requested changes
Jan 26, 2026
Contributor
val-ms
left a comment
val-ms
left a comment
There was a problem hiding this comment.
Overall I'm impressed with this PR.
I haven't tested it yet, so my comments far are just from code review.
of uri, git, or none. Documentation describing these changes is incluided in this commit.
val-ms
requested changes
Feb 9, 2026
Contributor
val-ms
left a comment
val-ms
left a comment
There was a problem hiding this comment.
The code looks good, outside of breaking support for the older 'url' option.
I need to play with this now.
Comment on lines
255
to
261
| self.logger.warning( | ||
| f"Failed to load recipe: {fpath}" | ||
| ) | ||
| self.logger.warning( | ||
| f"Missing required 'url' field." | ||
| f"Recipe must have a 'source' field." | ||
| ) | ||
| continue |
Contributor
There was a problem hiding this comment.
I'd like to see backwards compatibility with the older "url" option which is why I suggested deprecating instead of replacing.
Contributor
There was a problem hiding this comment.
I.e. I see this right now:
❯ msl build -t host-static -r clamav_deps
/Users/val/dev/clamav/mussels/.venv/lib/python3.9/site-packages/urllib3/__init__.py:35: NotOpenSSLWarning: urllib3 v2 only supports OpenSSL 1.1.1+, currently the 'ssl' module is compiled with 'LibreSSL 2.8.3'. See: https://github.com/urllib3/urllib3/issues/3020
warnings.warn(
2026-02-09 14:46:02 Mussels WARNING Failed to load recipe: /Users/val/.mussels/cookbooks/scrapbook/recipes/template.yaml
2026-02-09 14:46:02 Mussels WARNING Recipe must have a 'source' field.
2026-02-09 14:46:02 Mussels WARNING Failed to load recipe: /Users/val/.mussels/cookbooks/scrapbook/recipes/template_cmake.yaml
2026-02-09 14:46:02 Mussels WARNING Recipe must have a 'source' field.
2026-02-09 14:46:02 Mussels WARNING Failed to load recipe:
....
2026-02-09 14:46:03 Mussels WARNING Recipe must have a 'source' field.
2026-02-09 14:46:03 Mussels WARNING Failed to load recipe: /Users/val/.mussels/cookbooks/clamav/recipes/libjson-c-0.yaml
2026-02-09 14:46:03 Mussels WARNING Recipe must have a 'source' field.
2026-02-09 14:46:03 Mussels ERROR clamav_deps build failed!
2026-02-09 14:46:03 Mussels WARNING Failed to assemble dependency chain for clamav_deps on Darwin (host-static):
2026-02-09 14:46:03 Mussels WARNING The clamav:libz recipe, required by clamav:clamav_deps-1.5 has dependency issues...
2026-02-09 14:46:03 Mussels WARNING 'libz'
Contributor
There was a problem hiding this comment.
I tried copying the pcre2 recipe, plus libbz2 and libz dependencies and using the source: with git:, branch:, tag:, and uri: options and they worked nicely. 👍
jhumlick
force-pushed
the
CLAM-2938-add-depot_tools-support
branch
from
1b43f41 to
da44744
Compare
A top-level 'url' field is functionally equivalent to source.uri but if both are specified, source.uri takes precedence. This allows for backwards-compatibility with older recipes.
jhumlick
force-pushed
the
CLAM-2938-add-depot_tools-support
branch
from
da44744 to
be658af
Compare
val-ms
requested changes
Feb 26, 2026
Comment on lines
+253
to
261
| # Check for source field with valid configuration | ||
| if "source" not in yaml_file: | ||
| self.logger.warning( | ||
| f"Failed to load recipe: {fpath}" | ||
| ) | ||
| self.logger.warning( | ||
| f"Missing required 'url' field." | ||
| f"Recipe must have a 'source' field." | ||
| ) | ||
| continue |
Contributor
There was a problem hiding this comment.
@jhumlick this still fails for existing recipes that just have the 'url' field because of this code. After the change, please try testing using https://github.com/Cisco-Talos/clamav-mussels-cookbook/
Contributor
Author
There was a problem hiding this comment.
This should be fixed now.
val-ms
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to support some specialized build environments (i.e. Google), it is necessary to provide the ability to obtain sources via other means. This commit adds this functionality, and a future commit will add recipes which use these new features.
CLAM-2938