LandSimulation constructor for ITime dt + start and end dates #1404
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliasloan25
force-pushed
the
js/itime-sim
branch
from
8bee89d to
5523043
Compare
juliasloan25
changed the title
imreddyTeja
approved these changes
Sep 8, 2025
Member
imreddyTeja
left a comment
imreddyTeja
left a comment
There was a problem hiding this comment.
It might be a good idea to ensure that this works with the coupler before making the release.
Member
Author
|
Tested from ClimaCoupler and passing here: https://buildkite.com/clima/climacoupler-ci/builds/6913 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The LandSimulation constructor that takes in
start_dateandend_dateas DateTimes previously only accepteddtas a Float or Dates.Second. This PR allowsdtto also be anITime, and asserts that in this casedt.epoch == start_date. This is a case used by ClimaCoupler.To-do