Adding automated weighting function#178
Merged
sajjadazimi merged 33 commits intomainfrom Dec 18, 2025
Merged
Conversation
Member
|
Hi @ekdejong :) |
sajjadazimi
approved these changes
Dec 11, 2025
| compute_threshold(pdists; percentile) | ||
| `pdists` - tuple of particle size distributions | ||
| `percentile` - mass percentile | ||
| Returns a tuple of new integral thresholds, one for each pdist, computed using the given percentile |
Member
There was a problem hiding this comment.
It's good to add a couple of sentences how you compute these thresholds mathematically.
| @@ -0,0 +1,40 @@ | |||
| "Box model with two gamma modes" | |||
Member
There was a problem hiding this comment.
Do you want to add this to buildkite?
Member
Author
There was a problem hiding this comment.
Yes, I added in latest commit. Good idea!
2e829d7 to
839d1fd
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #178 +/- ##
==========================================
- Coverage 98.17% 95.35% -2.83%
==========================================
Files 8 9 +1
Lines 493 538 +45
==========================================
+ Hits 484 513 +29
- Misses 9 25 +16 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Adds an alternative option for the weighting function in which size thresholds for "autoconversion" are computed on the fly based on set percentiles of each subdistribution.
Content