Skip to content

Adding automated weighting function#178

Merged
sajjadazimi merged 33 commits intomainfrom
ej/weighting
Dec 18, 2025
Merged

Adding automated weighting function#178
sajjadazimi merged 33 commits intomainfrom
ej/weighting

Conversation

@ekdejong
Copy link
Member

@ekdejong ekdejong commented Feb 2, 2025

Purpose

Adds an alternative option for the weighting function in which size thresholds for "autoconversion" are computed on the fly based on set percentiles of each subdistribution.

Content

  • Includes additional functionality in source code (Particle Distributions, Coalescence)
  • Example ('*moving.jl')
  • Unit tests
  • Updates to CI & buildkite environment

  • I have read and checked the items on the review checklist.

@ekdejong ekdejong requested a review from sajjadazimi December 10, 2025 01:33
@trontrytel
Copy link
Member

Hi @ekdejong :)

Copy link
Member

@sajjadazimi sajjadazimi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM!

compute_threshold(pdists; percentile)
`pdists` - tuple of particle size distributions
`percentile` - mass percentile
Returns a tuple of new integral thresholds, one for each pdist, computed using the given percentile
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's good to add a couple of sentences how you compute these thresholds mathematically.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, just added

@@ -0,0 +1,40 @@
"Box model with two gamma modes"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to add this to buildkite?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I added in latest commit. Good idea!

@codecov
Copy link

codecov bot commented Dec 18, 2025

Codecov Report

❌ Patch coverage is 57.57576% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 95.35%. Comparing base (29b59bb) to head (d8dfa79).
⚠️ Report is 25 commits behind head on main.

Files with missing lines Patch % Lines
src/Sources/Coalescence.jl 22.22% 14 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #178      +/-   ##
==========================================
- Coverage   98.17%   95.35%   -2.83%     
==========================================
  Files           8        9       +1     
  Lines         493      538      +45     
==========================================
+ Hits          484      513      +29     
- Misses          9       25      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sajjadazimi sajjadazimi merged commit 3f2bfd3 into main Dec 18, 2025
9 of 11 checks passed
@sajjadazimi sajjadazimi deleted the ej/weighting branch December 18, 2025 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants