Add Initial Support for Interval Types (Starting With IntervalNanosecond)#71
Open
faridmehrhesam wants to merge 1 commit intoClickHouse:mainfrom
Open
Add Initial Support for Interval Types (Starting With IntervalNanosecond)#71faridmehrhesam wants to merge 1 commit intoClickHouse:mainfrom
faridmehrhesam wants to merge 1 commit intoClickHouse:mainfrom
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Collaborator
|
Thanks for this! The docs say the interval should be unsigned, but some quick tests show that is not actually the case, will have to investigate that a bit. Adding the rest of the interval types would be useful as well, maybe with a common base class and then just multiplying the TimeSpan by some factor? |
Author
|
Thanks for the feedback. I’ll continue the implementation and review the docs to stay aligned. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces initial support for ClickHouse Interval types, beginning with IntervalNanosecond.
Before implementing the full family of interval types, I’d like to get early feedback to ensure that the approach, structure, and overall direction align with the project’s standards.
What’s Included
Let me know about the approach, code quality, test coverage, and anything else that should be included before extending support to all interval types — and after the full implementation I will follow the version-update instructions accordingly
Checklist