Add typed errors and gRPC status code conversion#227
Open
Vikramarjuna wants to merge 1 commit intoCloud-Foundations:masterfrom
Open
Add typed errors and gRPC status code conversion#227Vikramarjuna wants to merge 1 commit intoCloud-Foundations:masterfrom
Vikramarjuna wants to merge 1 commit intoCloud-Foundations:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Typed Errors and gRPC Status Code Conversion
Why
Introduce typed errors so that errors returned with proper types can be handled better by callers. This enables:
errors.As(err, &NotFoundError{}))Existing code can continue using string-based errors -
ErrorToStatus()includes pattern matching as a fallback. New code should gradually adopt typed errors.What
lib/errors/types.go: Typed errors implementingCodedErrorinterface (NotFoundError, PermissionDeniedError, InvalidArgumentError, etc.)lib/srpc/errors.go:ErrorToStatus()function for converting errors to gRPC status codes