Add ability to pull images from a private registry #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Limited to a single registry and user.
nuwang
reviewed
Jan 30, 2021
| /usr/local/bin/kubectl create secret -n {{ app_namespace }} docker-registry | ||
| --docker-server={{ registry_server }} --docker-username={{ registry_username }} | ||
| --docker-password={{ registry_password }} {{ registry_name }} | ||
| ignore_errors: true |
Contributor
There was a problem hiding this comment.
Can we make this rerunnable, so that it's possible to update the secret?
nuwang
reviewed
Jan 30, 2021
roles/cloudman-boot/tasks/main.yaml
Outdated
| when: cm_skip_cloudman is not defined or not (cm_skip_cloudman|bool) | ||
|
|
||
| - name: Configure private registries | ||
| include_tasks: private_repos.yml |
Contributor
There was a problem hiding this comment.
May be better to rename this to private_registries.yml?
nuwang
reviewed
Jan 30, 2021
Comment on lines
33
to
36
| registry_server: "https://index.docker.io/v1/" | ||
| registry_username: "{{ lookup('env', 'REGISTRY_USERNAME') }}" | ||
| registry_password: "{{ lookup('env', 'REGISTRY_PASSWORD') }}" | ||
| registry_name: "{{ lookup('env', 'REGISTRY_NAME') }}" |
Contributor
There was a problem hiding this comment.
Suggested change
| registry_server: "https://index.docker.io/v1/" | |
| registry_username: "{{ lookup('env', 'REGISTRY_USERNAME') }}" | |
| registry_password: "{{ lookup('env', 'REGISTRY_PASSWORD') }}" | |
| registry_name: "{{ lookup('env', 'REGISTRY_NAME') }}" | |
| docker_registry_server: "https://index.docker.io/v1/" | |
| docker_registry_username: "{{ lookup('env', 'REGISTRY_USERNAME') }}" | |
| docker_registry_password: "{{ lookup('env', 'REGISTRY_PASSWORD') }}" | |
| docker_registry_name: "{{ lookup('env', 'REGISTRY_NAME') }}" |
Contributor
|
ping @afgane |
Co-authored-by: Nuwan Goonasekera <2070605+nuwang@users.noreply.github.com>
nuwang
force-pushed
the
master
branch
2 times, most recently
from
24160e8 to
786d73c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Limited to a single registry and user.