Fix inconsistency with add operator, Added switch/case, Added default pipeline, Filter block with format function#95
Conversation
|
I rebased all of your work on top of the current master and reworked the commits some (dropping unnecessary merges, combining fixup commits). I went through the code yesterday and understand only half of it so I'll add some tests next. I might also split out the + operator changes as I mentioned in #93. |
|
Sorry that this takes so long but I'm not comfortable with merging this before I add at least a couple more test cases. I will do that this week. |
|
Hi ! |
|
@annismckenzie ping! :) |
|
ping @annismckenzie <3 |
|
@tooolbox @Dexus I can do a rebase of this branch against the current master but then it'd be up to someone else to test this as I currently don't have the bandwidth to make sure this monster of a PR is good to go. The project where I used Jet extensively was replaced just a couple days ago after working on a single page application for the last 2 years… so I'm effectively not using Jet anymore in production. Any thoughts? |
|
Sigh, made a mistake with a push. Don't really know what happened here on the upstream. I rebased everything and will open up a new PR. Sorry guys. |
|
No prob @annismckenzie Sure, don't mind doing some testing. |
|
That's greatly appreciated! I'll try to write up some more tests for the parts that don't have any yet (default etc.). The branch in #136 is rebased against the current master with Go modules on v3. Can you take that for a spin? |
|
@annismckenzie will take it for a test in our dev. |
5 participants
#93