Birmingham| SEP_2025| Hadi Vahidi | Sprint 1 | Feature wireframe #755
Conversation
add 2 more article
…und cover the full width
|
Your PR's title isn't in the expected format. Please check the expected title format, and update yours to match. Reason: Sprint part (Sprint-1) doesn't match expected format (example: 'Sprint 2', without quotes) |
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
HadiVahidi20
added
the
Needs Review
|
Your PR's title isn't in the expected format. Please check the expected title format, and update yours to match. Reason: Sprint part (Sprint-1) doesn't match expected format (example: 'Sprint 2', without quotes) |
HadiVahidi20
changed the title
|
Your PR's title isn't in the expected format. Please check the expected title format, and update yours to match. Reason: Sprint part (Sprint_1) doesn't match expected format (example: 'Sprint 2', without quotes) |
HadiVahidi20
changed the title
|
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. |
LonMcGregor
added
the
Review in progress
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Good start on this sprint's tasks, I have spotted a few areas where you could improve code further
| </main> | ||
| <footer> | ||
| <p> | ||
| this is my first web page on code your future | © Hadi Vahidi. |
There was a problem hiding this comment.
One of the acceptance criteria for this task is making sure the footer is fixed to the viewport. Do you know what that means? Can you fix that?
Wireframe/index.html
Outdated
| </header> | ||
| <main> | ||
| <article> | ||
| <img src="placeholder.svg" alt="" /> |
There was a problem hiding this comment.
Currently all the images are placeholders - do you know what that means? Can you think of how this could be improved?
Wireframe/index.html
Outdated
| <p> | ||
| A README file provides an overview of a project, explaining what it does, how to install and use it, and who created it. It can also include guidelines for contributing, contact information, and links to additional resources. Essentially, it helps users and developers quickly understand and work with the project. | ||
| </p> | ||
| <a href="">Read more</a> |
There was a problem hiding this comment.
Right now these links don't go anywhere. Can you think of where they should link to?
LonMcGregor
added
Reviewed
Create a new folder to add images.
Images added.
|
I see you have made changes here. If you want them reviewed, remember to add the "needs review" label on this PR. |
|
Thanks for your review.
I am still working on it and as soon I finished I will label it review
needed
Thank you
…On Wed, Sep 10, 2025, 11:34 AM LonMcGregor ***@***.***> wrote:
*LonMcGregor* left a comment (CodeYourFuture/Module-Onboarding#755)
<#755 (comment)>
I see you have made changes here. If you want them reviewed, remember to
add the "needs review" label on this PR.
—
Reply to this email directly, view it on GitHub
<#755 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BNQVX5XT7WINJUCRDV2ZQR33R75DFAVCNFSM6AAAAACF3BMZU2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTENZUGM2DCOJYGU>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
…g the main content
HadiVahidi20
added
Needs Review
|
Great work - this page looks much neater now. You can close this sprint task as complete now |
LonMcGregor
added
Complete
3 participants
Learners, PR Template
Self checklist
Changelist
I created two more articles. and updated the CSS
Questions
thank you I have no question.