Glasgow | 25-ITP-SEP | Mohammed Abdoon | Sprint 2 | Form-Controls #756
Conversation
… form + username minlength validation addded so it accepts only valid names with 2 charachters at least
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Your PR couldn't be matched to an assignment in this module. Please check its title is in the correct format, and that you only have one PR per assignment. If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). |
4 similar comments
|
Your PR couldn't be matched to an assignment in this module. Please check its title is in the correct format, and that you only have one PR per assignment. If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). |
|
Your PR couldn't be matched to an assignment in this module. Please check its title is in the correct format, and that you only have one PR per assignment. If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). |
|
Your PR couldn't be matched to an assignment in this module. Please check its title is in the correct format, and that you only have one PR per assignment. If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). |
|
Your PR couldn't be matched to an assignment in this module. Please check its title is in the correct format, and that you only have one PR per assignment. If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). |
M-Abdoon
changed the title
|
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. |
M-Abdoon
changed the title
|
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. |
1 similar comment
|
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. |
wilsonadenuga
added
Review in progress
wilsonadenuga
left a comment
wilsonadenuga
left a comment
There was a problem hiding this comment.
The wireframe folder should not be a part of this pull request, can remove it?
What steps do you think you could take to make sure changes from one PR don't show up in another unrelated PR?
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
wilsonadenuga
added
Reviewed
M-Abdoon
added
Needs Review
wilsonadenuga
added
Review in progress
wilsonadenuga
left a comment
wilsonadenuga
left a comment
There was a problem hiding this comment.
Changes look good 😎
There are some errors in your code, you can validate using https://validator.w3.org/
wilsonadenuga
added
Reviewed
I validated the code using validator.w3.org. Thank you ^^ |
M-Abdoon
added
Needs Review
|
@M-Abdoon, you closed this PR, Is that intentional? |
I reopened the PR again, sorry that was unintentional. |
wilsonadenuga
added
Complete
3 participants
I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide
I have completed the task. I created a form that collects user input to verify their identity by entering their name and email address, and to capture their product preferences.