London | 25-ITP-Sep | Adnaan Abo | Sprint 1 | Wireframe #758
Conversation
modified: Wireframe/style.css
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. |
4 similar comments
|
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. |
|
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. |
|
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. |
|
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. |
AdnaanA
added
📅 Sprint 1
|
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. |
1 similar comment
|
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. |
LonMcGregor
added
Review in progress
|
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. |
1 similar comment
|
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. |
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Good start on this sprint's tasks, I have spotted a few areas where you could improve code further
In the pull requests "Changelist" section, it is expected that you give a brief explanation of what major changes you made. You can remove the default text once you've done that.
Wireframe/index.html
Outdated
| <article> | ||
| <img src="placeholder.svg" alt="" /> | ||
| <h2>Title</h2> | ||
| <img src="placeholder.svg" alt="image showing a readme file" width="100%"/> |
There was a problem hiding this comment.
Currently all the images are placeholders - do you know what that means? Can you think of how this could be improved?
There was a problem hiding this comment.
Thanks for the feedback. I have now fixed the above issue I have replaced the placeholder images with more appropriate images.
| <div class="footer-content"> | ||
| <p> | ||
| This is the default, provided code and no changes have been made yet. | ||
| © 2025 AdnaanA. Built with VSCode and GitHub. |
There was a problem hiding this comment.
One of the acceptance criteria for this task is making sure the footer is fixed to the viewport. Do you know what that means? Can you fix that?
There was a problem hiding this comment.
thank you for the feed back. I have now fixed the footer to the viewport.
LonMcGregor
added
Reviewed
|
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. |
1 similar comment
|
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. |
new file: Wireframe/images/readme.png new file: Wireframe/images/wireframe.png modified: Wireframe/index.html modified: Wireframe/style.css
AdnaanA
added
the
Needs Review
|
Great work - this sprint looks complete now |
LonMcGregor
added
Complete
3 participants
Self checklist
wireframe PR created using html and CSS while following the provided guidelines.