Skip to content
Closed
Show file tree
Hide file tree
Changes from 22 commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Form-Controls/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ Let's write out our testable criteria. Check each one off as you complete it.
- [ ] My Lighthouse Accessibility score is 100.
- [ ] I require a valid name. I have defined a valid name as a text string of two characters or more.
- [ ] I require a valid email.
- [ ] I require one colour from a defined set of 3 colours.
- [ ] I requiolourre one colour from a defined set of 3 cs.
- [ ] I require one size from a defined set of 6 sizes.

## Resources
Expand Down
138 changes: 113 additions & 25 deletions Form-Controls/index.html
Original file line number Diff line number Diff line change
@@ -1,27 +1,115 @@
<!DOCTYPE html>
<html lang="en">
<head>
<meta charset="utf-8" />
<meta http-equiv="X-UA-Compatible" content="IE=edge" />
<title>My form exercise</title>
<meta name="description" content="" />
<meta name="viewport" content="width=device-width, initial-scale=1" />
</head>
<body>
<header>
<h1>Product Pick</h1>
</header>
<main>
<form>
<!-- write your html here-->
<!--
try writing out the requirements first as comments
this will also help you fill in your PR message later-->
</form>
</main>
<footer>
<!-- change to your name-->
<h2>By HOMEWORK SOLUTION</h2>
</footer>
</body>
</html>

<head>
<meta charset="utf-8" />
<meta http-equiv="X-UA-Compatible" content="IE=edge" />
<title>My form exercise</title>
<meta name="description" content="" />
<meta name="viewport" content="width=device-width, initial-scale=1" />
</head>

<body>
<header>
<h1>Product </h1>
</header>
<main>
<!-- Write a valid form / Test with Devtools/Refactor using Devtools -->

<form>
<!-- customer's name/ require-->
<fieldset>
<legend>
<h2> Pick Your T-shirt</h2>
</legend>
<p>
Required fields are followed by
<strong><span aria-label="required">*</span></strong>
</p>

<p>
<label for="name"><strong>Name *</strong></label>
</p>
<input type="text" id="name" name="user_name" required minlength="2" />

<!-- customer's e-amil/ require-->

<p><label for="e-mail"><span><strong>E-mail *</strong></span></label>
</p>
<input type="email" id="e-mail" name="user_email" required />

<!-- 3 options colour/ pick only 1/ require -->

<label for="colour-YELLOW">
Copy link
Contributor

@jenny-alexander jenny-alexander Oct 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normally when defining html attributes, we use lowercase characters.
Can you review your "for" and "id" attribute names and ensure they are in lowercase?

<p><strong>Colour:</strong></p>
<input type="radio" style="transform: scale(2)" id="colour-YELLOW" value="YELLOW" name="colour" required />
<span>Yellow </span> </span>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small typo at line 46. Can you find it?

</label>

<label for="colour-RED">
<input type="radio" style="transform: scale(2)" id="colour-RED" value="RED" name="colour" required />
<span>Red </span>
</label>

<label for="colour-BLUE">
<input type="radio" style="transform: scale(2)" id="colour-BLUE" value="BLUE" name="colour" required />
<span>Blue </span>
</label>

Copy link
Contributor

@jenny-alexander jenny-alexander Oct 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you review all of the radio button values? They have value ="color-*" instead of the size value (for example,value="BLUE").

<!--6 options: XS, S, M, L, XL, XXL/ pick only 1 / require-->
<p><strong>Size:</strong></p>
<ul>

<li>
<label for="size-XS">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you check the value of the "for" attribute in your XS size select label and the corresponding "id" value? There is a typo here.

<input type="radio" style="transform: scale(1.5); margin-bottom: 20px"; id="colour-XS" name="size"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At line 65, the style syntax has a small error. The semi-colon should not be outside of the quotes. Can you fix it?
I see this typo for all inline styling of size radio buttons.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Della-Bella Can you check the other size radio buttons? The semi-colon is outside the double quotes and it should be inside the quotes.
Screenshot 2025-10-01 at 8 51 45 PM

value="colour-XS" required><span> XS </span>
</label>
</li>

<li>
<label for="size-S">
<input type="radio" style="transform: scale(1.5) ; margin-bottom: 20px"; id="size-S" name="size" value="colour-S"
required><span> S </span>
</label>
</li>

<li>
<label for="size-M">
<input type="radio" style="transform: scale(1.5); margin-bottom: 20px"; id="size-M" name="size" value="colour-M"
required><span> M </span>
</label>
</li>

<li>
<label for="size-L">
<input type="radio" style="transform: scale(1.5); margin-bottom: 20px"; id="size-L" name="size" value="colour-L"
required><span> L </span>
</label>
</li>

<li>
<label for="size-XL">
<input type="radio" style="transform: scale(1.5); margin-bottom: 20px"; id="size-XL" name="size" value="colour-XL"
required><span> XL </span>
</label>
</li>

<li>
<label for="-XXL">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small typo on line 99, can you find it?

<input type="radio" style="transform: scale(1.5); margin-bottom: 20px"; id="size-XXL" name="size" value="colour-XXL"
required><span> XXL</span>
</label>
</li>
</ul>
<button type="submit">Add To Cart </button>
</fieldset>
</form>
</main>
<footer>
<!-- change to your name-->
<h3>By Gisline Della Bella</h3>
</footer>
</body>

</html>
Binary file added Wireframe/img/branch.jpg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added Wireframe/img/header.jpg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added Wireframe/img/icon-instagram.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added Wireframe/img/icon-linkedin.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added Wireframe/img/main.jpg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added Wireframe/img/read.jpg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added Wireframe/img/wireframe.jpg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
128 changes: 102 additions & 26 deletions Wireframe/index.html
Original file line number Diff line number Diff line change
@@ -1,33 +1,109 @@
<!DOCTYPE html>
<html lang="en">
<head>
<meta charset="UTF-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<title>Wireframe</title>
<link rel="stylesheet" href="style.css" />
</head>
<body>
<header>
<h1>Wireframe</h1>
<p>
This is the default, provided code and no changes have been made yet.
</p>
</header>
<main>
<article>
<img src="placeholder.svg" alt="" />
<h2>Title</h2>

<head>
<meta charset="UTF-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<link href="https://fonts.googleapis.com/css2?family=Montserrat:wght@400;700&display=swap" rel="stylesheet">
<title>Wireframe</title>
<link rel="stylesheet" href="style.css" />
</head>

<body>
<!--Header-->
<header>
<nav>
<a href="#readme">ReadMe</a> |
<a href="#wireframe">Wireframe</a> |
<a href="#branch">Branch</a>
</nav>

<h1>Wireframe</h1>
<p class="subtext">
The fundamental structure and content hierarchy of a digital product
</p>

</header>

<!--End Header-->

<!--Main -->
<main>
<main class="card-container">

<article class="card">
<h2 id="readme">README File </h2>
<p>
Lorem ipsum dolor sit amet consectetur adipisicing elit. Quisquam,
voluptates. Quisquam, voluptates.
A README file is a text file that describes and launches a project. It comprises information that is
frequently needed
to grasp the scope of the project. In this blog, we will talk about what a README file is, why is it necessary
and how
you can write a good README file.
</p>
<a href="">Read more</a>
<a class="card-link" href="https://www.mygreatlearning.com/blog/readme-file/" target="_blank">Read more</a>
<img class="img-card" src="img/read.jpg" alt="documento folder on a table" />
</article>

<article class="card">
<h2 id="wireframe">What is the purpose of a wireframe?</h2>
<p>
The primary purpose of a wireframe is to serve as a blueprint or skeletal outline for a digital product, like
a website
or app, focusing on the structure, layout, and placement of content and features rather than visual aesthetics
</p>
<a class="card-link" href="https://balsamiq.com/blog/what-are-wireframes/#:~:text=A%20wireframe%20is%20the%20skeleton,teammates%2C%20stakeholders%2C%20or%20clients."
target="_blank">Read more</a>
<img class="img-card" src="img/wireframe.jpg" alt="" />
</article>

<article class="card">
<h2 id="branch">What is a branch in Git?</h2>
<p>
A branch in Git is simply a lightweight movable pointer to one of these commits. The default branch name in
Git is
master . As you start making commits, you're given a master branch that points to the last commit you made.
Every time
you commit, the master branch pointer moves forward automatically.
</p>
<a class="card-link" href="https://git-scm.com/book/en/v2/Git-Branching-Branches-in-a-Nutshell#:~:text=A%20branch%20in%20Git%20is,branch%20pointer%20moves%20forward%20automatically."
target="_blank" >Read more</a>
<img class="img-card" src="img/branch.jpg" alt="a womman looking at a tech screen" />
</article>

</main>
<footer>
<p>
This is the default, provided code and no changes have been made yet.
</p>
<!--End Main -->

<!--Footer -->
<footer class="footer-container">


<div class="info">
<p class="email"><a href="mailto:enquires@worldtech.com">enquires@worldtech.com</a></p>
<p> +44 (0) 321 654 0789</p>
<p> www.worldtechnews.com</p>
</div>

<div class="adress">

<p> 56 World Road</p>
<p>NLondon</p>
<p> NT5 4PG</p>
<p> United Kingdom</p>
</div>

<div class="social">


<a href="https://www.instagram.com/" class="social-icon" target="_blank">
<img src="img/icon-instagram.png" alt="Instagram">
</a>
<a href="https://uk.linkedin.com/" class="social-icon" target="_blank">
<img src="img/icon-linkedin.png" alt="Instagram">
</a>


</footer>
</body>
</html>
<!--End Footer -->
</body>

</html>
Loading