Skip to content

Manchester | Jan 26 | Joanne O'Malley | Sprint 2 | Form Controls #922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
joanne342 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Manchester | Jan 26 | Joanne O'Malley | Sprint 2 | Form Controls #922

joanne342 wants to merge 1 commit into from

Conversation

@joanne342
Copy link

@joanne342 joanne342 commented Jan 5, 2026 •
edited
Loading

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

Made an HTML-only form that take's the customer's name, email address and desired T-shirt colour and size.

@netlify
Copy link

netlify bot commented Jan 5, 2026 •
edited
Loading

✅ Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit 330bb20
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/695bad0f5d489b0008b548ef
😎 Deploy Preview https://deploy-preview-922--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 2 paths audited
Performance: 95 (🔴 down 5 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 84 (🔴 down 2 from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@joanne342 joanne342 added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. 🏕 Priority Mandatory This work is expected 🐂 Size Medium 1-4 hours 📅 Sprint 2 Assigned during Sprint 2 of this module Submit:PR This work is submitted by creating a PR against CodeYourFuture's fork of this repo. Module-Onboarding The name of the module. Core This is a core task and should be completed by all trainees labels Jan 5, 2026
@joanne342 joanne342 changed the title North West | Jan 26 | Joanne O'Malley | Onboarding Sprint 2 | Form Controls North West | Jan 26 | Joanne O'Malley | Sprint 2 | Form Controls Jan 5, 2026
@joanne342 joanne342 changed the title North West | Jan 26 | Joanne O'Malley | Sprint 2 | Form Controls North West | Jan 26 | Joanne O'Malley | Onboarding Sprint 2 | Form Controls Jan 5, 2026
@joanne342 joanne342 changed the title North West | Jan 26 | Joanne O'Malley | Onboarding Sprint 2 | Form Controls Manchester | Jan 26 | Joanne O'Malley | Sprint 2 | Form Controls Jan 5, 2026
@joanne342 joanne342 changed the title Manchester | Jan 26 | Joanne O'Malley | Sprint 2 | Form Controls Manchester| 25-ITP-September| Joanne O'Malley| Sprint 2 | Form Controls Jan 5, 2026
@joanne342 joanne342 changed the title Manchester| 25-ITP-September| Joanne O'Malley| Sprint 2 | Form Controls Manchester| 26-ITP-January| Joanne O'Malley| Sprint 2 | Form Controls Jan 5, 2026
@joanne342 joanne342 changed the title Manchester| 26-ITP-January| Joanne O'Malley| Sprint 2 | Form Controls Manchester | 26-ITP-January | Joanne O'Malley | Sprint 2 | Form Controls Jan 5, 2026
@joanne342 joanne342 changed the title Manchester | 26-ITP-January | Joanne O'Malley | Sprint 2 | Form Controls Manchester | Jan 26 | Joanne O'Malley | Sprint 2 | Form Controls Jan 5, 2026
illicitonion
illicitonion reviewed Jan 10, 2026
View reviewed changes
Copy link
Member

@illicitonion illicitonion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! There's one issue, which is that when I run lighthouse on this page, it has one problem. Can you take a look?

@illicitonion illicitonion added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jan 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@illicitonion illicitonion illicitonion left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

Core This is a core task and should be completed by all trainees Module-Onboarding The name of the module. 🏕 Priority Mandatory This work is expected Reviewed Volunteer to add when completing a review with trainee action still to take. 🐂 Size Medium 1-4 hours 📅 Sprint 2 Assigned during Sprint 2 of this module Submit:PR This work is submitted by creating a PR against CodeYourFuture's fork of this repo.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@joanne342 @illicitonion