feat(rendering): align 'primary' note heads instead of centering #2426
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Danielku15
changed the title
Danielku15
force-pushed
the
feature/note-head-align
branch
from
00921bd to
fa72c06
Compare
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
Relates to #2247
Proposed changes
Reworks some parts of the note head placement to align more with the industry practices. Generally the "correctly placed" notes (stem upwards left, stem down right) should be aligned. Also the note "heads" of other staves (e.g. tab numbers) should align with the main note heads.
Next step towards #2247 is to place note heads looking at all voices displacing and shifting them as required.
Checklist
Further details