feat: advanced font configurations and lyric paddings #2481
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit b1c8233109788524c991aef77a74649f1b6f0104)
(cherry picked from commit 583cecafc38fbcbdd20059422ecb016463a15ffb)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
Fixes #2396
Proposed changes
This PR significantly reworks how we can specify fonts in alphaTab. instead of having individual properties, we have now a map mapping
NotationElementto the fonts to be used.This allows individual font configurations for all effects and annotations.
Additionally this PR allows customizing the padding between lyric lines.
Checklist
Further details