fix: prevent endless loops due to invalid bpms #2484
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 8b150a98b17ef6c472c387b46ad5cfa94d9b7692)
Danielku15
force-pushed
the
feature/zero-bpm
branch
3 times, most recently
from
c4bfac3 to
ea69983
Compare
(cherry picked from commit d5e4b3519cd921d5e486350f87cf2565a6ebe2f8) chore: clean import
Danielku15
force-pushed
the
feature/zero-bpm
branch
from
ea69983 to
5ea0408
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
Fixes #2465
Proposed changes
We cropped fractional bpms in MusicXML which caused 0.111bpm to be cropped to 0. THen 0bpm caused an endlessloop and divisions by zero in the sequencer.
This PR prevents these problems by avoiding truncation and enforcing a minimum of 1bpm for playback.
Checklist
Further details