fix: ensure clean beam-stem alignment on subpixel rendering #2494
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
Fixes #2487
Proposed changes
Seems this problems was actually in since a while (already released). Due to some rounding "optimizations" the beams turned out wobbly.
We now do rounding at alternative places to avoid a wobbly slant:
This way we have a clean slant in most scenarios. The only exception is when the stem is wide enough to have a visual horizontal line. This in this case we have a bit of a slope-plane-slope effect.
To avoid this alphaTab would need to bigger rework the beam drawing by drawing the beams as far as possible with 1 beam instead a beat-to-beat drawing as it is today. We can improve this if it really becomes a problem for someone.
Checklist
Further details