fix: avoid placeholder reuse on content change #2495
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
Fixes #2488
Proposed changes
We now avoid reusing the viewport in cases where we detect that the content has changed significantly. This avoids partials keeping their content causing weird/wrong notation being shown when having a larger re-rendering.
e.g. when switching between layouts the content of the partials has to be cleared. Same when the whole rendered score changes.
In cases where the developer knows the score should be same/similar, a new
RenderingHintsobject specifying that the viewport should be reused. This provides a better experience when doing live-editing.Checklist
Further details