Skip to content

fix: [find] improve search result display and parsing#1016

Merged
deepin-ci-robot merged 1 commit intoCodeya-IDE:masterfrom
Kakueeen:session
Dec 11, 2024
Merged

fix: [find] improve search result display and parsing#1016
deepin-ci-robot merged 1 commit intoCodeya-IDE:masterfrom
Kakueeen:session

Conversation

@Kakueeen
Copy link
Contributor

@Kakueeen Kakueeen commented Dec 9, 2024

Enhance search result handling and display in multiple aspects:

  • Add content truncation for large search results to prevent parsing issues
  • Optimize search result text display with proper trimming and formatting
  • Improve regex pattern for parsing search results with non-greedy matching
  • Add content side length limit for better readability
  • Refactor result model to handle data updates more efficiently

The changes focus on improving stability and user experience when handling large search results, while maintaining performance.

Log: fix search result display and parsing issues

@Kakueeen Kakueeen force-pushed the session branch 3 times, most recently from adf4ff3 to 2ca2501 Compare December 9, 2024 09:51
Enhance search result handling and display in multiple aspects:
- Add content truncation for large search results to prevent parsing issues
- Optimize search result text display with proper trimming and formatting
- Improve regex pattern for parsing search results with non-greedy matching
- Add content side length limit for better readability
- Refactor result model to handle data updates more efficiently

The changes focus on improving stability and user experience when handling large search results, while maintaining performance.

Log: fix search result display and parsing issues
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • encodecombobox.cpp中,新增了DGuiApplicationHelper的包含,但未看到对应的代码修改,需要确认是否有必要。
  • searchresultitemdelegate.cpp中,adjustContent函数增加了对格式范围的调整,但未看到对drawDisplay函数的相应修改,可能会导致显示问题。
  • searchresultitemdelegate.cpp中,drawDisplay函数中移除了对显示文本的修剪,这可能会影响文本的显示效果。
  • searchresultmodel.cpp中,findGroup函数的返回值类型从QList<QString>改为QString,但未看到对应的调用修改,可能会导致编译错误。
  • searchreplaceworker.cpp中,对resultLineRegex的正则表达式进行了修改,但未看到对应的调用修改,可能会导致正则表达式匹配失败。

是否建议立即修改:

  • 确认新增的DGuiApplicationHelper包含是否必要,并检查是否有相应的代码修改。
  • 修改adjustContent函数以保持与drawDisplay函数的一致性,并确保文本的显示效果正确。
  • 检查searchresultmodel.cppfindGroup函数的返回值类型修改,并确保所有调用该函数的地方都已更新。
  • 重新评估searchreplaceworker.cppresultLineRegex的正则表达式修改,并确保所有相关的正则表达式匹配逻辑都已更新。

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deepin-mozart, Kakueeen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-ci-robot deepin-ci-robot merged commit 083720a into Codeya-IDE:master Dec 11, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants