Skip to content

fix: build faild on mips#1108

Merged
deepin-mozart merged 1 commit intoCodeya-IDE:masterfrom
deepin-mozart:master
Apr 24, 2025
Merged

fix: build faild on mips#1108
deepin-mozart merged 1 commit intoCodeya-IDE:masterfrom
deepin-mozart:master

Conversation

@deepin-mozart
Copy link
Contributor

@deepin-mozart deepin-mozart commented Apr 24, 2025

Log:
Change-Id: Ic993dce88f06fa0744d2ae0bc2ddd1b1b4ab9a8a

Summary by Sourcery

Modify platform-specific build configuration to handle MIPS64 platform compatibility

Bug Fixes:

  • Resolve build configuration issues for MIPS64 architecture by updating conditional compilation flags

Enhancements:

  • Improve platform detection and conditional compilation for unsupported platforms

Build:

  • Update CMake configuration to detect MIPS64 system processor and define a new platform-specific macro

Log:
Change-Id: Ic993dce88f06fa0744d2ae0bc2ddd1b1b4ab9a8a
@sourcery-ai
Copy link

sourcery-ai bot commented Apr 24, 2025

Reviewer's Guide by Sourcery

This pull request fixes a build failure on mips by disabling webengine on unsupported platforms and updating the debian control file.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Added a compiler definition to disable webengine on unsupported platforms.
  • Added a compiler definition UNSUPPORTPLATFORM when the system processor is mips64.
  • Defined NOT_USE_WEBENGINE when UNSUPPORTPLATFORM is defined.
src/plugins/core/CMakeLists.txt
src/plugins/core/gui/plugindetailsview.h
Updated the debian control file.
  • Updated the debian control file.
debian/control

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@github-actions
Copy link

  • 检测到debian目录文件有变更: debian/control

@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • debian/control文件中,移除了对特定架构(如mipselmips64el)的依赖项排除,这可能会影响其他架构的构建。
  • CMakeLists.txt文件中,将处理器检查从loongarch64更改为mips64,并且添加了一个新的宏定义-DUNSUPPORTPLATFORM,这可能会影响其他平台的构建。
  • plugindetailsview.h文件中,将LOONGARCH64宏定义更改为UNSUPPORTPLATFORM,这可能会影响使用WebEngine的平台的构建。

是否建议立即修改:

建议的修改:

  • debian/control文件中,如果移除特定架构的依赖项排除是为了支持更多架构,请确保这些架构的构建过程已经过充分测试。
  • CMakeLists.txt文件中,如果mips64架构的构建过程已经过充分测试,并且-DUNSUPPORTPLATFORM宏定义是正确的,那么可以保留这些更改。否则,应该恢复到原来的处理器检查。
  • plugindetailsview.h文件中,如果UNSUPPORTPLATFORM宏定义是正确的,并且已经考虑了所有相关平台的构建,那么可以保留这些更改。否则,应该恢复到原来的宏定义。

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @deepin-mozart - I've reviewed your changes - here's some feedback:

Overall Comments:

  • The commit message is not very informative; please provide more context about the build failure and how this change resolves it.
  • Consider using a more descriptive macro name than UNSUPPORTPLATFORM, perhaps something like DISABLE_WEBENGINE.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@github-actions
Copy link

  • 敏感词检查失败, 检测到1个文件存在敏感词
详情
{
    "debian/control": [
        {
            "line": "Homepage: http://www.deepin.org",
            "line_number": 49,
            "rule": "S35",
            "reason": "Url link | 6fe814dfb7"
        }
    ]
}

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deepin-mozart, LiHua000

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-mozart deepin-mozart merged commit 6f7e93b into Codeya-IDE:master Apr 24, 2025
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants