fix: build faild on mips#1108
Conversation
Log: Change-Id: Ic993dce88f06fa0744d2ae0bc2ddd1b1b4ab9a8a
Reviewer's Guide by SourceryThis pull request fixes a build failure on mips by disabling webengine on unsupported platforms and updating the debian control file. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
Warning
|
deepin pr auto review关键摘要:
是否建议立即修改:
建议的修改:
|
There was a problem hiding this comment.
Hey @deepin-mozart - I've reviewed your changes - here's some feedback:
Overall Comments:
- The commit message is not very informative; please provide more context about the build failure and how this change resolves it.
- Consider using a more descriptive macro name than
UNSUPPORTPLATFORM, perhaps something likeDISABLE_WEBENGINE.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
Note
详情{
"debian/control": [
{
"line": "Homepage: http://www.deepin.org",
"line_number": 49,
"rule": "S35",
"reason": "Url link | 6fe814dfb7"
}
]
} |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deepin-mozart, LiHua000 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Log:
Change-Id: Ic993dce88f06fa0744d2ae0bc2ddd1b1b4ab9a8a
Summary by Sourcery
Modify platform-specific build configuration to handle MIPS64 platform compatibility
Bug Fixes:
Enhancements:
Build: