Skip to content

chore: refactor core cmakelists dependency#1109

Merged
deepin-ci-robot merged 1 commit intoCodeya-IDE:masterfrom
deepin-mozart:master
Apr 24, 2025
Merged

chore: refactor core cmakelists dependency#1109
deepin-ci-robot merged 1 commit intoCodeya-IDE:masterfrom
deepin-mozart:master

Conversation

@deepin-mozart
Copy link
Contributor

@deepin-mozart deepin-mozart commented Apr 24, 2025

Log:
Change-Id: Idb7407697c0280e6a04919ff29b661dd7d24ca93

Summary by Sourcery

Refactor CMake configuration for core plugin to simplify WebEngineWidgets dependency handling across different platforms

Build:

  • Updated platform-specific WebEngineWidgets handling for mips64 and loongarch64 platforms

Chores:

  • Simplified platform-specific WebEngineWidgets configuration in CMakeLists.txt by consolidating platform checks

Log:
Change-Id: Idb7407697c0280e6a04919ff29b661dd7d24ca93
@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deepin-mozart

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • CMakeLists.txt文件中,对于mips64loongarch64平台,分别使用了add_definitionsmessage来处理不支持的平台,但没有对其他平台进行相应的处理。
  • find_packagetarget_link_libraries的调用被移动到了else分支,这可能会导致在mips64平台下无法找到WebEngineWidgets

是否建议立即修改:

建议的修改措施:

  • CMakeLists.txt中,应该添加对其他平台的处理逻辑,以确保所有平台都能正确处理。
  • 对于mips64平台,应该确保WebEngineWidgets的查找和链接逻辑是正确的,而不是简单地跳过。
  • 如果loongarch64平台不支持WebEngineWidgets,应该考虑移除相关的条件判断,或者提供更明确的注释说明为什么这个平台不支持WebEngineWidgets

@sourcery-ai
Copy link

sourcery-ai bot commented Apr 24, 2025

Reviewer's Guide by Sourcery

The pull request refactors the way WebEngineWidgets is included in the core plugin's CMakeLists.txt. It now skips WebEngineWidgets for mips64 and removes the specific handling for loongarch64, streamlining the dependency management.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Refactored the inclusion of WebEngineWidgets based on the CMAKE_SYSTEM_PROCESSOR variable.
  • Moved the find_package and target_link_libraries calls for WebEngineWidgets inside an else block that checks if the processor is mips64.
  • Added a message indicating that WebEngineWidgets is being skipped for the mips64 platform.
  • Removed the conditional inclusion of WebEngineWidgets based on the loongarch64 architecture.
src/plugins/core/CMakeLists.txt

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @deepin-mozart - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider extracting the platform check into a separate function or macro for better readability.
  • It looks like you're trying to remove a duplicate block of code, but the logic is slightly different - double check that the new logic is correct.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@deepin-ci-robot deepin-ci-robot merged commit 27551a0 into Codeya-IDE:master Apr 24, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants