Skip to content

chore: refactor core cmake file#1110

Merged
deepin-ci-robot merged 1 commit intoCodeya-IDE:masterfrom
deepin-mozart:master
Apr 25, 2025
Merged

chore: refactor core cmake file#1110
deepin-ci-robot merged 1 commit intoCodeya-IDE:masterfrom
deepin-mozart:master

Conversation

@deepin-mozart
Copy link
Contributor

@deepin-mozart deepin-mozart commented Apr 25, 2025

Log:
Change-Id: I94f88659da449e9c229ad5f6573d051e55b03001

Summary by Sourcery

Refactor CMake configuration for core plugin to improve platform-specific WebEngineWidgets handling

Build:

  • Modify CMake configuration to conditionally include WebEngineWidgets based on system processor

Chores:

  • Restructure WebEngineWidgets configuration to handle platform-specific requirements more explicitly

Log:
Change-Id: I94f88659da449e9c229ad5f6573d051e55b03001
@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deepin-mozart

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sourcery-ai
Copy link

sourcery-ai bot commented Apr 25, 2025

Reviewer's Guide by Sourcery

This pull request refactors the CMakeLists.txt file for the core plugin to improve the conditional compilation of WebEngineWidgets based on the target architecture. The changes involve moving the find_package and target_link_libraries calls inside the if block and updating the message to include the architecture.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Refactor the conditional compilation of WebEngineWidgets based on the target architecture.
  • Move the find_package and target_link_libraries calls for WebEngineWidgets inside the if block.
  • Update the message to include the architecture.
src/plugins/core/CMakeLists.txt

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • 代码逻辑调整后,确保了WebEngineWidgets仅在非mips64平台下被查找和链接。
  • 消息字符串更新为动态显示当前系统处理器类型,提高了代码的可读性。

是否建议立即修改:

  • 否,提交的代码没有明显的错误,逻辑清晰,且修改后的代码更易于理解和维护。

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @deepin-mozart - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider using CMAKE_HOST_SYSTEM_PROCESSOR instead of CMAKE_SYSTEM_PROCESSOR to detect the host architecture.
Here's what I looked at during the review
  • 🟡 General issues: 1 issue found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@@ -4,10 +4,7 @@ project(core)

if(${CMAKE_SYSTEM_PROCESSOR} STREQUAL "mips64")
add_definitions(-DUNSUPPORTPLATFORM)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue (typo): Possible typo: UNSUPPORTPLATFORM should be UNSUPPORTEDPLATFORM

It appears there might be a typo in the macro definition. Did you mean to use UNSUPPORTEDPLATFORM instead of UNSUPPORTPLATFORM?

Suggested change
add_definitions(-DUNSUPPORTPLATFORM)
add_definitions(-DUNSUPPORTEDPLATFORM)

@deepin-ci-robot deepin-ci-robot merged commit 8d33848 into Codeya-IDE:master Apr 25, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants