chore: refactor core cmake file#1110
Conversation
Log: Change-Id: I94f88659da449e9c229ad5f6573d051e55b03001
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deepin-mozart The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Reviewer's Guide by SourceryThis pull request refactors the CMakeLists.txt file for the core plugin to improve the conditional compilation of WebEngineWidgets based on the target architecture. The changes involve moving the No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
deepin pr auto review关键摘要:
是否建议立即修改:
|
There was a problem hiding this comment.
Hey @deepin-mozart - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider using
CMAKE_HOST_SYSTEM_PROCESSORinstead ofCMAKE_SYSTEM_PROCESSORto detect the host architecture.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| @@ -4,10 +4,7 @@ project(core) | |||
|
|
|||
| if(${CMAKE_SYSTEM_PROCESSOR} STREQUAL "mips64") | |||
| add_definitions(-DUNSUPPORTPLATFORM) | |||
There was a problem hiding this comment.
issue (typo): Possible typo: UNSUPPORTPLATFORM should be UNSUPPORTEDPLATFORM
It appears there might be a typo in the macro definition. Did you mean to use UNSUPPORTEDPLATFORM instead of UNSUPPORTPLATFORM?
| add_definitions(-DUNSUPPORTPLATFORM) | |
| add_definitions(-DUNSUPPORTEDPLATFORM) |
Log:
Change-Id: I94f88659da449e9c229ad5f6573d051e55b03001
Summary by Sourcery
Refactor CMake configuration for core plugin to improve platform-specific WebEngineWidgets handling
Build:
Chores: