fix: crash when use inlinechat

[deepin-mozart]

Log:
Bug: https://pms.uniontech.com/bug-view-314743.html Change-Id: I9ccdb5b6ad4bf6e51d805e6b71aef77098fdd540

Summary by Sourcery

Bug Fixes:

• Resolved a potential crash in the inline chat widget by fixing the lambda capture mechanism when creating a prompt

[deepin-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deepin-mozart

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• debian/deepin/OWNERS [deepin-mozart]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request fixes a crash that occurs when using inline chat. The crash was caused by a memory management issue in the InlineChatWidgetPrivate::askForChat function. The fix involves ensuring that the question variable is captured by value in the lambda expression passed to QtConcurrent::run. This prevents the variable from being accessed after it has gone out of scope, which was causing the crash.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change	Details	Files
Capture 'question' by value in the lambda expression to prevent accessing a variable after it has gone out of scope.	Modified the lambda expression in InlineChatWidgetPrivate::askForChat to capture the question variable by value instead of by reference.	src/plugins/chat/widgets/inlinechatwidget.cpp

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[deepin-ci-robot]

deepin pr auto review

关键摘要:

• 代码中使用了Lambda表达式来捕获this指针和question变量，这是一个好的做法，可以避免在异步操作中直接使用this指针可能带来的问题。
• 在Lambda表达式中捕获question变量时，使用了[this, question]，这是一个正确的捕获方式，确保了Lambda表达式内部可以访问question变量。

是否建议立即修改:

• 否，提交的代码没有明显的语法错误或逻辑问题。
• 是，建议添加一些注释来解释为什么选择使用Lambda表达式，以及Lambda表达式是如何工作的，这对于代码的可读性和维护性是有帮助的。

[sourcery-ai]

Hey @deepin-mozart - I've reviewed your changes - here's some feedback:

Overall Comments:

• Consider using std::move(question) in the lambda capture to avoid a potential copy.

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}