fix: crashed when open plugin detail page#1113
Merged
deepin-ci-robot merged 1 commit intoCodeya-IDE:masterfrom Apr 28, 2025
Merged
fix: crashed when open plugin detail page#1113deepin-ci-robot merged 1 commit intoCodeya-IDE:masterfrom
deepin-ci-robot merged 1 commit intoCodeya-IDE:masterfrom
Conversation
Log: Bug: https://pms.uniontech.com/bug-view-314807.html Change-Id: Ica69be9473023d282fb3e3ed5b09e2188d61d65e
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deepin-mozart The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
deepin pr auto review关键摘要:
是否建议立即修改:
|
Reviewer's Guide by SourceryConditionalize OpenGL setting for ARM architecture based on Wayland usage to fix crash on plugin detail page. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey @deepin-mozart - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider the rendering behavior on ARM systems that are not running Wayland, as this change restricts the OpenGLES setting specifically to Wayland environments.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Log:
Bug: https://pms.uniontech.com/bug-view-314807.html Change-Id: Ica69be9473023d282fb3e3ed5b09e2188d61d65e
Summary by Sourcery
Bug Fixes: