Show chest name for those with invalid world#18
Open
PikaMug wants to merge 1 commit intoCodisimus:masterfrom
PikaMug:patch-1
Open
Show chest name for those with invalid world#18PikaMug wants to merge 1 commit intoCodisimus:masterfrom PikaMug:patch-1
PikaMug wants to merge 1 commit intoCodisimus:masterfrom
PikaMug:patch-1
Conversation
Will help the user to edit or remove the afflicted PhatLoot, especially if there are multiple chests in the same world. Have not tested this, but I assume chestName is not empty at this point.
Owner
|
chestName is simply a copy of what is provided in the config file so each time it would print out rather than the name of the PhatLoot. |
Owner
|
There might be a different variable that we can use though. Let me take a look. |
Owner
|
It doesn't even look like that code is called anywhere. It is a private constructor that is not called within that file. |
Contributor
Author
|
That code is called somewhere when the server starts up, when data exists for a chest in a world which has been removed. My server changes worlds often, so any way to identify which chest the warning refers to would be magical. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Will help the user to edit or remove the afflicted PhatLoot, especially if there are multiple chests in the same world. Have not tested this, but I assume chestName is not empty at this point.