Open
Conversation
vijayamadhavareddy
requested changes
May 31, 2025
| } | ||
|
|
||
| const listenHandler = async <T>(db_url: string, opitons: Options<T>) => { | ||
| export const listenHandler = async <T>(db_url: string, opitons: Options<T>) => { |
Contributor
There was a problem hiding this comment.
Why did we make this exported ?
Collaborator
Author
There was a problem hiding this comment.
Sir, inorder to write testcases for it
| }; | ||
|
|
||
| const subscribeHandler = async <T>(db_url: string, opitons: Options<T>) => { | ||
| export const subscribeHandler = async <T>( |
Contributor
There was a problem hiding this comment.
Why did we made this public ?
Collaborator
Author
There was a problem hiding this comment.
To write testcases for it sir
| @@ -0,0 +1,15 @@ | |||
| import { jest } from '@jest/globals'; | |||
|
|
|||
| if (typeof window !== 'undefined') { | |||
Contributor
There was a problem hiding this comment.
What is the purpose of this setup ?
Collaborator
Author
There was a problem hiding this comment.
I reffered other projects for jest setup sir, but I think this is not needed in this
| import { getQueue } from '../queue-adapters/adapter'; | ||
|
|
||
| const getHandler = async <T>(consumer: Consumer<T>) => { | ||
| export const getHandler = async <T>(consumer: Consumer<T>) => { |
Contributor
There was a problem hiding this comment.
Why did we export this ?
Collaborator
Author
It is in the first PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.