This repository was archived by the owner on Jun 30, 2025. It is now read-only.
CU-8699gfb13 Environment info calculation at import time #93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new value is a default factory, which should be called lazily by pydantic instead of at import time.
This will avoid import time initialisation and subsequent call to environment info.
…ethod isn't called at import time
mart-r
changed the title
mart-r
added a commit
that referenced
this pull request
Jun 20, 2025
* CU-8699gfb13: Update the default value for environment in config. The new value is a default factory, which should be called lazily by pydantic instead of at import time. * CU-8699gfb13: Update config meta data default value. This will avoid import time initialisation and subsequent call to environment info. * CU-8699gfb13: Add a simple test to make sure the environmental info method isn't called at import time
alhendrickson
pushed a commit
to CogStack/cogstack-nlp
that referenced
this pull request
Jun 24, 2025
…dCAT2#93) * CU-8699gfb13: Update the default value for environment in config. The new value is a default factory, which should be called lazily by pydantic instead of at import time. * CU-8699gfb13: Update config meta data default value. This will avoid import time initialisation and subsequent call to environment info. * CU-8699gfb13: Add a simple test to make sure the environmental info method isn't called at import time
alhendrickson
pushed a commit
to CogStack/cogstack-nlp
that referenced
this pull request
Jun 24, 2025
…dCAT2#93) * CU-8699gfb13: Update the default value for environment in config. The new value is a default factory, which should be called lazily by pydantic instead of at import time. * CU-8699gfb13: Update config meta data default value. This will avoid import time initialisation and subsequent call to environment info. * CU-8699gfb13: Add a simple test to make sure the environmental info method isn't called at import time
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
medcat.utils.envsnapshot.get_environment_infomethod was called to find the default value forConfig.meta.saved_environat import time.However, this can be problematic if/when the environment isn't completely loaded at import time.
So this PR does the following:
ModelMeta.saved_environfield aFieldwith adefault_factorypydanticthen calls the factory lazily only when neededConfig.metafield aFieldwith adefault_factoryModelMetaclass was initialised and the method called at import time anyway