Skip to content

Fix quicksave sorting #251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Enorovan wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix quicksave sorting #251

Enorovan wants to merge 3 commits into from

Conversation

@Enorovan
Copy link
Member

@Enorovan Enorovan commented Sep 7, 2025 •
edited
Loading

  • Properly sort quicksaves in C;CLCC
  • Fix GetQuickSaveOpenSlot

Closes #167

@KKhanhH KKhanhH force-pushed the quick-save-cycle branch 2 times, most recently from 1fa5e10 to 2333cb6 Compare October 3, 2025 07:06
@Enorovan
Copy link
Member Author

Enorovan commented Oct 30, 2025

https://stackoverflow.com/a/58037981/27686485

@Enorovan Enorovan force-pushed the quick-save-cycle branch 3 times, most recently from e74acbd to 6c667b3 Compare November 2, 2025 22:38
@Enorovan Enorovan marked this pull request as ready for review November 2, 2025 22:52
KKhanhH
KKhanhH reviewed Nov 2, 2025
View reviewed changes
KKhanhH
KKhanhH reviewed Nov 2, 2025
View reviewed changes
@Enorovan Enorovan requested a review from KKhanhH November 2, 2025 23:08
PringlesGang
PringlesGang requested changes Nov 3, 2025
View reviewed changes
src/ui/widgets/chlcc/saveentrybutton.cpp
SaveDateHintTextRelativePos);
const tm& date = SaveSystem::GetSaveDate(entryType, Id);
AddSaveDateText(fmt::format(" {:%y/%m/%d}", date), 18,
AddSaveDateText(fmt::format(" {:%m/%d/%y}", date), 18,
Copy link
Member

@PringlesGang PringlesGang Nov 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JP has (the superior 💪) y/m/d. I'd put this behind a profile enum (to also potentially support the more universal d/m/y)

Copy link
Collaborator

@KKhanhH KKhanhH Nov 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or maybe just based on language selection, just to be consistent with other games

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PringlesGang PringlesGang PringlesGang requested changes

@KKhanhH KKhanhH Awaiting requested review from KKhanhH

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Make C;CLCC quicksaves cycle properly

4 participants

@Enorovan @KKhanhH @PringlesGang