CHLCC: Menus Polish #365

Gunoshozo · 2026-01-04T15:42:02Z

CHLCC: Menus Polish

Sound:

Add scrollbar support
Add click support for switching playback mode
Fix misaligned elements ("Select ***" text and Menu Title text mostly) and animations

Tips:

Start with right page
Fix sprites bounds

Sound, Movie, CG:

Add "Select ***" animation based on the Tip's menu "Select Word" animation

Sound, Movie, CG, Save/Load:

Simplify sprite loading for "Select ***" in .lua

Tips, Save/Load, Title, Sound, Movie, CG:

Use one implementation for all "Select ***" animation (via composition)

Backlog, Clear, Tips, Save/Load, Title, Sound, Movie, CG, Options, Trophy:

Use one implementation for "Show Menu" animation taken from Options menu (via composition)

Bonus:

Shave off 16 bytes of every Animation (Widget has Animation field)
Shave off 8 bytes of every Menu

src/profile/games/chlcc/systemmenu.cpp

src/games/chlcc/animations/selectprompt.h

src/games/chlcc/albummenu.cpp

src/games/chlcc/musicmenu.h

src/games/chlcc/animations/selectprompt.cpp

src/profile/games/chlcc/optionsmenu.cpp

Sound: - Add scrollbar support - Add click support for switching playback mode - Fix misaligned elements and animations Tips: - Start with right page - Fix sprites bounds System Messages: - Fix 1px sprite gap for a button Sound, Movie, CG: - Add "Select ***" animation based on the Tip's menu "Select Word" animation Sound, Movie, CG, Save/Load: - Simplify sprite loading for "Select ***" in .lua Tips, Save/Load, Title, Sound, Movie, CG: - Use one implementation for all "Select ***" animation (via composition) Backlog, Clear, Tips, Save/Load, Title, Sound, Movie, CG, Options, Trophy: - Use one implementation for "Show Menu" animation taken from Options menu (via composition) Bonus: - Shave off 16 bytes of every Animation (Widget has Animation field) - Shave off 8 bytes of every Menu

Enorovan

The Select Animations sure are better and the missing inputs in Sound Menu work

KKhanhH

What's the behavioral changes for the music menu scrolling? Do cross input interactions work well, like scrollbar partial scroll then switch to kb/gamepad, backing out and in from a partial scroll, scroll hold, etc

KKhanhH · 2026-01-11T23:39:03Z

src/ui/widgets/scrollbar.h


 class Scrollbar : public Widget {
 public:
+  Scrollbar() {};


Do = default

KKhanhH · 2026-01-11T23:44:20Z

src/profile/ui/gamespecific.h

 inline uint8_t ButterflyFrameCount;
 inline float ButterflyFlapFrameDuration;
 inline float ButterflyFadeDuration;
+inline float MenuSelectPromptDuration;


These would be much better suited in a common menu profile file but thats not in yet so I'll let it slide

KKhanhH · 2026-01-15T06:11:21Z

src/games/chlcc/animations/selectprompt.h

+class SelectPromptAnimation : public Animation {
+ public:
+  SelectPromptAnimation();
+  void Draw(const std::span<const Sprite> sprites,


Dont make function arguments value const in header files

KKhanhH · 2026-01-15T06:17:10Z

src/profile/games/chlcc/tipsmenu.cpp

  SelectWordPos = GetMemberVector<glm::vec2>("SelectWordPos");
-  SelectWordDuration = EnsureGetMember<float>("SelectWordDuration");
-  SelectWordInterval = EnsureGetMember<float>("SelectWordInterval");
+  assert(SelectWordSprites.size() == SelectWordPos.size());


I think we throw an exception or something if this asserts false, its in the init stages anyway so might as well catch it rather than bug out in releases

KKhanhH · 2026-01-15T06:17:36Z

src/profile/games/chlcc/systemmenu.cpp

+  SelectMenuHeader = GetMemberVector<Sprite>("SelectMenuSprites");
+  SelectMenuHeaderPositions =
+      GetMemberVector<glm::vec2>("SelectMenuTextPositions");
+  assert(SelectMenuHeader.size() == SelectMenuHeaderPositions.size());


KKhanhH · 2026-01-15T06:18:49Z

src/profile/games/chlcc/moviemenu.cpp

-  GetMemberArray<Sprite>(SelectMovie, 11, "SelectMovie");
-  GetMemberArray<glm::vec2>(SelectMoviePos, 11, "SelectMoviePos");
+  SelectMovie = GetMemberVector<Sprite>("SelectMovie");
+  SelectMoviePos = GetMemberVector<glm::vec2>("SelectMoviePos");


This one doesn't have a check

KKhanhH · 2026-01-15T06:19:37Z

src/profile/games/chlcc/albummenu.cpp

-  GetMemberArray<Sprite>(SelectData, 10, "SelectData");
-  GetMemberArray<glm::vec2>(SelectDataPos, 10, "SelectDataPos");
+  SelectDataSprites = GetMemberVector<Sprite>("SelectDataSprites");
+  SelectDataPos = GetMemberVector<glm::vec2>("SelectDataPos");


This one also has no check

KKhanhH · 2026-01-15T06:30:29Z

src/games/chlcc/musicmenu.cpp

 using namespace Impacto::Vm::Interface;

+constexpr bool isRepeatOne(MusicPlaybackMode playbackMode) {
+  return to_underlying(playbackMode) &


You could overload operators for & and ^, then wouldn't need a specialty function or spam to_underlying everywhere

KKhanhH · 2026-01-15T06:31:27Z

src/games/chlcc/musicmenu.cpp

-  MenuTransition.SetDuration(MenuTransitionDuration);
+void MusicMenu::ToggleRepeatMode() {
+  PlaybackMode =
+      (MusicPlaybackMode)(to_underlying(PlaybackMode) ^


Does ^= work?

KKhanhH · 2026-01-15T06:48:09Z

src/games/chlcc/musicmenu.cpp


+  // adjusts sprite height to prevent visual bug tied to mouse support (1px of
+  // out of bounds highlight sprite can be visible)
+  TrackHighlight.Bounds = TrackHighlight.Bounds.ScaleAroundCenter(


This modifies a profile sprite, can you instead modify the trackbutton code?

Gunoshozo marked this pull request as draft January 4, 2026 15:42

Gunoshozo force-pushed the chlcc/music-menu-polish branch 4 times, most recently from 58069c9 to 7702594 Compare January 7, 2026 18:19

Gunoshozo changed the title ~~CHLCC: Music menu Polish~~ CHLCC: Menus Polish Jan 7, 2026

Gunoshozo force-pushed the chlcc/music-menu-polish branch from 7702594 to ebd724c Compare January 9, 2026 17:45

Enorovan linked an issue Jan 9, 2026 that may be closed by this pull request

Fix multiplat input in Library Menus #199

Open

Gunoshozo force-pushed the chlcc/music-menu-polish branch from ebd724c to 619487d Compare January 10, 2026 16:15

Gunoshozo marked this pull request as ready for review January 10, 2026 16:18

Gunoshozo requested review from Enorovan, KKhanhH and PringlesGang January 10, 2026 16:18

PringlesGang requested changes Jan 11, 2026

View reviewed changes

Gunoshozo force-pushed the chlcc/music-menu-polish branch from 619487d to 62a0164 Compare January 11, 2026 23:19

PringlesGang requested changes Jan 11, 2026

View reviewed changes

src/profile/games/chlcc/optionsmenu.cpp Show resolved Hide resolved

Enorovan added the game-chlcc CHAOS;HEAD Love Chu☆Chu! label Jan 12, 2026

Gunoshozo force-pushed the chlcc/music-menu-polish branch from 62a0164 to fd5dda1 Compare January 14, 2026 17:10

Gunoshozo force-pushed the chlcc/music-menu-polish branch from fd5dda1 to 6a771bf Compare January 14, 2026 17:29

Gunoshozo requested a review from PringlesGang January 14, 2026 18:09

Enorovan approved these changes Jan 14, 2026

View reviewed changes

KKhanhH requested changes Jan 15, 2026

View reviewed changes

Gunoshozo self-assigned this Jan 16, 2026

Resolve PR Issues & Improve scrolling behavior for music menu

4846e24

Gunoshozo force-pushed the chlcc/music-menu-polish branch from 5c7c532 to 4846e24 Compare January 17, 2026 17:27

CHLCC: Menus Polish #365

Are you sure you want to change the base?

CHLCC: Menus Polish #365

Uh oh!

Conversation

Gunoshozo commented Jan 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Enorovan left a comment

Choose a reason for hiding this comment

Uh oh!

KKhanhH left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Gunoshozo commented Jan 4, 2026 •

edited

Loading