Generalize crime viz to incomplete trajectories#4
Open
michael-hoss wants to merge 2 commits intoCommonRoad:developfrom
Open
Generalize crime viz to incomplete trajectories#4michael-hoss wants to merge 2 commits intoCommonRoad:developfrom
michael-hoss wants to merge 2 commits intoCommonRoad:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi 👋
I think so far, this visualization function assumed that all obstacles' trajectories would start at time step 1 and go until the end of the scenario (e.g. 20).
I noticed something was off when the argument
time_steps = [20]led to an error.state_list[time_steps[0] : time_steps[-1] + 1]becomesstate_list[20:21]then, but the indices ofstate_listonly go from 0 to 19 (for time steps 1 to 20).Then I also realized it might be worth while fully generalizing it to the case that certain trajectories begin later than 1 and end sooner than 20, while the plot argument could still be
time_steps = [1, 20]or even[0,20].Is this worth while generalizing or are scenarios typically composed in a way all objects last from beginning to end? Since I don't know yet, I also haven't tested this function on such a scenario yet.