T2792 Ensure child protection on children page

[Shayan105]

This PR is linked to this one : CompassionCH/compassion-website#211

[gemini-code-assist]

Summary of Changes

Hello @Shayan105, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances child protection by implementing a mechanism to obfuscate the precise geographical coordinates of projects. It introduces new data fields and logic to retrieve and store less precise location data, ensuring that sensitive information is not directly exposed while still providing a general sense of location. This change is crucial for maintaining privacy on public-facing pages, such as the children's page.

Highlights

• New Obfuscated Coordinate Fields: Two new fields, gps_latitude_obfuscated and gps_longitude_obfuscated, have been added to the CompassionProject model to store privacy-preserving location data.
• Google Maps Geocoding Integration: A new method update_obfuscated_coordinates was introduced to fetch and store obfuscated coordinates for projects using the Google Maps Geocoding API, ensuring an API key is configured before making requests.
• Safe Coordinate Exposure: A get_obfuscated_coordinates_json method has been added to provide obfuscated coordinates in JSON format. If obfuscated coordinates are not available, it falls back to returning the integer part of the real coordinates for a rough, non-precise location.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a feature to obfuscate project coordinates to enhance child protection, which is a great initiative. The implementation involves adding new fields and a method to fetch obfuscated coordinates from the Google Geocoding API. While the overall approach is sound, I've identified a critical bug in the fallback logic for coordinates, which could lead to incorrect location data being sent. Additionally, there are several opportunities to improve the robustness and performance of the external API communication, such as adding timeouts, handling exceptions more specifically, and considering the performance impact of making API calls in a loop. Addressing these points will make the feature more reliable and resilient.

[ecino]

Suggested change

	# Check if we already have coords to avoid wasting API calls
	if project.gps_latitude_obfuscated or project.gps_longitude_obfuscated:
	continue

[Shayan105]

This logic should remain in case the compute method is called manually to avoid wasting API calls. However, when the compute method is triggered by a onchange(lat,long), this should indeed not be checked.

[ecino]

10 seconds seems blocking for me. It should be faster.

Suggested change

	response = requests.get(base_url, params=params, timeout=10)
	response = requests.get(base_url, params=params, timeout=3)

[ecino]

Raising an error for applying the integer obfuscation.

Suggested change

	logging.error(f"Geocoding error for {project.id}: {data['status']}")
	raise UserError(f"Geocoding error for {project.id}: {data['status']}")