Implementation of concept, devConcept and philosophicalConcept#53
Open
SeyedMojtaba1 wants to merge 2 commits intomainfrom
Open
Implementation of concept, devConcept and philosophicalConcept#53SeyedMojtaba1 wants to merge 2 commits intomainfrom
SeyedMojtaba1 wants to merge 2 commits intomainfrom
Conversation
Open
mkermani144
requested changes
Dec 5, 2024
Seyed/TS_OOP/Concept.ts
Outdated
| this.name = n; | ||
| } | ||
|
|
||
| abstract get get_name(): string; |
Collaborator
There was a problem hiding this comment.
- You don't need a getter here, otherwise you have to access it like
concept.get_nameinstead ofconcept.get_name(), which is unexpected—this should be fixed for all occurrences - In JS, method names are camelCase by convention, not snake_case
- Is there a need to mark this method as abstract?
Collaborator
There was a problem hiding this comment.
In some other places, you still have used getters/setters, which is unexpected.
Seyed/TS_OOP/DevConcept.ts
Outdated
| import { concept } from "./Concept"; | ||
|
|
||
| class devConcept extends concept { | ||
| constructor(n: string, b: "architecture" | "clean-code" | "languages") { |
Collaborator
There was a problem hiding this comment.
This class doesn't need a name param. It's name is always devConcept.
Collaborator
Author
There was a problem hiding this comment.
I think that I didn't understand it.
But I fixed it.
Collaborator
There was a problem hiding this comment.
Let's discuss it in our meeting.
mkermani144
requested changes
Dec 7, 2024
Collaborator
mkermani144
left a comment
mkermani144
left a comment
There was a problem hiding this comment.
Please address the new comments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related #51