Unit tests for Job:getInstance, fix QlessTest class to be abstract #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for getInstance method
Contributor
|
This only contains unit tests, the fix isn't in here :) |
Contributor
Author
|
didn't need fixing. I was doing something else wrong and the docs on php.net were a bit misleading. |
Contributor
Author
|
did you ever do a PR to see if moz would take the concurrency code into qless-core? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make QlessTest abstract so phpunit does not try to run it (shows failure)
Add tests for Job:getInstance
Fixed TestWorkerImpl class name because it is not namespaced (tests never actually got far enough to use it), included it for base test class