[TECH-580] Add custom restore module check #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cPanelChrisD
suggested changes
Aug 23, 2018
Collaborator
cPanelChrisD
left a comment
cPanelChrisD
left a comment
There was a problem hiding this comment.
This passed perlcritic and perltidy and it worked as intended when I tested it. Only had some questions about the wording and INFO vs. WARN noted in another comment. Could you also please move this pull request to git.cpanel.net?
| return unless $found; | ||
|
|
||
| print_info('Custom Restore Modules: '); | ||
| print_normal("found in ${restoremodule_dir} -- can cause issues with restoration process if major version of cPanel was recently changed!"); |
Collaborator
There was a problem hiding this comment.
The wording of this feels like it should be a WARN rather than INFO, though in general the check fits in with the others around it. Maybe instead of the exclamatory text you could put a link to a document for more information, similar to the others?
Collaborator
|
@cPAusaf @davelcpanelnet This pull can be closed since it was done in 45dcf59 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Believe I did everything correctly (runs on my box as well and outputs correctly). If I messed anything up, please let me know.