Conversation
LoginPage is a class representing Page Object Model for the login page. As of now, it contains one method allowing to perform successful authentication.
Instead of repeating the same playwright calls to fetch the locators we use the Page Object Model pattern for the login page. I am still not sure if this is the correct approach. LoginPage class nicely encapsulates all playwright calls but there is quite a lot of boilerplate code.
Instead of repeating the same Playwright calls to fetch the locators we use the Page Object Model pattern for all currently used pages. I experimented with two approaches. The first approach was to reflect all possible actions with dedicated functions in page object. This ended up being a lot of boilerplate code. The second approach was to create the most popular selectors and save them as page object fields. Those locators that are used only one time, usually specific to the given test, are not included in the page object but created manually. This approach feels to be better for the current state of the project as it allows to avoid re-creating the same locators over and over again and at the same time we are not introducing too much boilerplate code.
CrazyPug
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of repeating the same Playwright calls to fetch the locators we use the Page Object pattern for all currently used pages.
I experimented with two approaches. The first approach was to reflect all possible actions with dedicated functions in page object. This ended up being a lot of boilerplate code. The second approach was to create the most popular selectors and save them as page object fields. Those locators that are used only one time, usually specific to the given test, are not included in the page object but created manually. This approach feels to be better for the current state of the project as it allows to avoid re-creating the same locators over and over again and at the same time we are not introducing too much boilerplate code.