Skip to content

Added few dropdown buttons#36

Open
sundeepgamini wants to merge 1 commit intomainfrom
sundeep-dropdown
Open

Added few dropdown buttons#36
sundeepgamini wants to merge 1 commit intomainfrom
sundeep-dropdown

Conversation

@sundeepgamini
Copy link
Collaborator

No description provided.

"eslint-plugin-react-refresh": "^0.4.3",
"eslint-plugin-storybook": "^0.6.13",
"less": "^4.2.0",
"sass": "^1.66.1",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need to install sass

export const customTheme = {
token: {
borderRadius: "4px",
borderRadiusLG: "8px",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use the tokens from https://github.com/Cromeror/Fanatics-Design-System/blob/main/themes/borderRadius.ts

Suggested change
borderRadiusLG: "8px",
borderRadiusLG: lightTheme.token.borderRadius


export const customTheme = {
token: {
borderRadius: "4px",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
borderRadius: "4px",
borderRadius: lightTheme.token.borderRadiusSmall,

Copy link
Owner

@Cromeror Cromeror left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LIGTM, just a few comments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants